London|ITP-September-2025|Mariia Serhiienko|Sprint 1|Implement #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js and max.test.js
…js and sum.test.js
…pe.js and dedupe.test.js
Konvaly
added
the
Needs Review
wheresdiasd
added
Review in progress
wheresdiasd
requested changes
Dec 1, 2025
| } | ||
|
|
||
| const filteredNumericArr = list.filter( | ||
| (el) => typeof el === "number" && Number.isFinite(el) |
There was a problem hiding this comment.
According to
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite
isFinite already checks if the element is a number ( typeof el === "number" ).
I like the usage of the method tho.
| const sortedArr = [...filteredNumericArr].sort((a, b) => a - b); | ||
| const middleIndex = Math.floor(sortedArr.length / 2); | ||
|
|
||
| if (sortedArr.length % 2 !== 0) { |
There was a problem hiding this comment.
Why do we need this last logic from 24 to 28 lines?
| (currMax, el) => Math.max(currMax, (String(el).split(".") || "").length), | ||
| 0 | ||
| ); | ||
| const decMultiplier = 10 ** maxDecimalPlaces; |
There was a problem hiding this comment.
This is a very robust solution, but too complex for the sake of the learning purposes, could we assume that the max float decimal places are 2 ? as we see in tests ?
|
|
||
| const total = numbers.reduce((acc, el) => acc + el, 0); | ||
|
|
||
| return Math.round((total + Number.EPSILON) * decMultiplier) / decMultiplier; |
There was a problem hiding this comment.
Therefore as a consequence of the comment above, we will not need Epsilon here as MathRound will do its work as expected.
wheresdiasd
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Added tests and implemented solution for the fix, implement and refactor sections