West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Todo list #893
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
MohammedNaru
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
MohammedNaru
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Your implementation does not quite follow the instructions in README.md.
The main objective of this exercise is to practice
- Modularizing code by separating UI and non-UI related code into separate files.
- Testing the non-UI related functions independently.
- Using ES module
On separate note, currently the deletion of individual Todo item is not working properly.
| function removeTodo(todos, todo) { | ||
| return todos.filter((t) => t !== todo); | ||
| } |
There was a problem hiding this comment.
.filter() creates a new array. The original todos[] is not updated accordingly.
| trashIcon.className = "fa fa-trash todo-icon"; | ||
| trashIcon.setAttribute("aria-hidden", "true"); | ||
| trashIcon.addEventListener("click", () => { | ||
| todos = removeTodo(todos, todo); |
There was a problem hiding this comment.
Line 34 only assigns an array to the local variable todos; it does not change the array passed to this function.
cjyuan
added
Reviewed
2 participants
Todo list Pull Request
Self checklist
Changelist
Refactored file changes to meet requirements and pass tests.
Questions
No questions for reviewer.