Skip to content

West Midlands | 25-ITP-Sept | Baba Yusuf | Sprint 3 | quote-generator #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

West Midlands | 25-ITP-Sept | Baba Yusuf | Sprint 3 | quote-generator #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11e30f5
Add initial implementation of mean calculation and tests
Baba05206 Nov 6, 2025
3cb29a0
Refactor mean calculation and tests for clarity and functionality
Baba05206 Nov 7, 2025
3d4c407
Update mean.js
Baba05206 Nov 18, 2025
7ed0f8a
Refactor index.html structure and enhance quotes.js functionality for…
Baba05206 Nov 28, 2025
b12fba7
Refactor displayRandomQuote function for improved readability and add…
Baba05206 Nov 28, 2025
3539f6a
deleted prep
Nov 29, 2025
2e420ba
fixed the testing of quote generator
Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<link rel="stylesheet" href="style.css" />
<script defer src="quotes.js"></script>
</head>
<body>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
<div class="main-container">
<div class="quote-box">
<p class="quote-mark">“</p>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
</div>
</div>
</body>
</html>
32 changes: 28 additions & 4 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@

function displayRandomQuote() {
const randomQuote = pickFromArray(quotes);
const quoteElement = document.getElementById("quote");
const authorElement = document.getElementById("author");
console.log(`quote: ${randomQuote.quote}`)
console.log(`author: ${randomQuote.author}`)

if (!quoteElement || !authorElement) return;

quoteElement.innerText = randomQuote.quote;
authorElement.innerText = randomQuote.author;
}

window.addEventListener("load", () => {
displayRandomQuote();

const newQuoteButton = document.getElementById("new-quote");
if (newQuoteButton) {
newQuoteButton.addEventListener("click", displayRandomQuote);
}
});
// DO NOT EDIT BELOW HERE

// pickFromArray is a function which will return one item, at
Expand All @@ -13,11 +35,15 @@
//
// Examples of use
// ---------------
// pickFromArray(['a','b','c','d']) // maybe returns 'c'
// pickFromArray(['a','b','c','d']) // maybe returns 'c'

// You don't need to change this function
function pickFromArray(choices) {
return choices[Math.floor(Math.random() * choices.length)];
var rnd = Math.random();
console.log(`random value ${rnd}`);
var found = choices[Math.floor(rnd * choices.length)];
console.log(`we chose ${found.quote} by ${found.author}`);
return found;
}

// A list of quotes you can use in your app.
Expand Down Expand Up @@ -489,5 +515,3 @@ const quotes = [
author: "Zig Ziglar",
},
];

// call pickFromArray with the quotes array to check you get a random quote
5 changes: 2 additions & 3 deletions Sprint-3/quote-generator/quotes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ There are some Tests in this file that will help you work out if your code is wo

const path = require("path");
const { JSDOM } = require("jsdom");
const { default: userEvent } = require("@testing-library/user-event");

let page = null;

Expand Down Expand Up @@ -61,14 +60,14 @@ describe("Quote generator", () => {
expect(authorP).toHaveTextContent("Albert Einstein");
expect(newQuoteBtn).toHaveTextContent("New quote");

userEvent.click(newQuoteBtn);
newQuoteBtn.click();

expect(quoteP).toHaveTextContent(
"I've learned that people will forget what you said, people will forget what you did, but people will never forget how you made them feel."
);
expect(authorP).toHaveTextContent("Maya Angelou");

userEvent.click(newQuoteBtn);
newQuoteBtn.click();

expect(quoteP).toHaveTextContent(
"I have learned over the years that when one's mind is made up, this diminishes fear."
Expand Down
70 changes: 69 additions & 1 deletion Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,69 @@
/** Write your CSS in here **/
body {
margin: 0;
font-family: sans-serif;
}

.main-container {
background-color: #ff9933;
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
padding: 20px;
}

.quote-box {
background-color: white;
padding: 40px;
max-width: 700px;
width: 90%;
box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
position: relative;
}

.quote-mark {
position: absolute;
top: 10px;
left: 20px;
font-size: 100px;
font-family: serif;
color: #ff9933;
margin: 0;
line-height: 1;
opacity: 0.6;
}

#quote {
font-size: 24px;
line-height: 1.5;
margin-top: 50px;
margin-bottom: 20px;
text-align: left;
padding-left: 15px;
}

#author {
font-size: 18px;
text-align: right;
margin-bottom: 30px;
margin-top: 0;
}

#author::before {
content: "- ";
}

#new-quote {
background-color: #ff9933;
color: white;
border: none;
padding: 10px 20px;
font-size: 16px;
cursor: pointer;
float: right;
transition: background-color 0.2s;
}

#new-quote:hover {
background-color: #e0872c;
}