West Midlands | 25-ITP-Sept | Baba Yusuf | Sprint 3 | quote-generator #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… random quote display
… event listener for new quote button
Baba05206
added
📅 Sprint 3
cjyuan
reviewed
Nov 29, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
You code looks good. Can you make this branch clean by deleting the "prep" folder?
-
Your
mainis 11 commits behind CYF'smain. You should update yourmainto ensure you have the latest content. -
You should also delete the
prepfolder in themainbranch. Otherwise all your branches will inherited theprepfolder. -
We should respect instructions like
DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPTWhy should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?
- You could place your code above the
DO NOT EDIT BELOW HEREinstruction on line 1.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented displayRandomQuote() function
Updated stylesheet file to make an attempt at matching the example quote generator
Updated the title in the index.html file as per task instruction. I also added a new div.
Questions
I was unable to get the tests to work to the right timings. How do i do this please?