Glasgow | ITP-SEP-25 | Alaa Tagi | Sprint 3 | feature/quote-generator

[Alaa-Tagi]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have completed all the tasks that required in this sprint.

Questions

No questions.

[jubelAhmed]

During initial load, if the JS script run before the DOM is ready?
Now fix all the comments

[jubelAhmed]

The quote-container element is not needed here

[jubelAhmed]

You can add condition after that is randomQuote is available or not, if not , then return

[jubelAhmed]

During initial load, if the script runs before the DOM is ready, getElementById may return null for these elements. This will cause a TypeError: Cannot set property 'innerText' of null when trying to access quoteText.innerText or quoteAuthor.innerText.

[jubelAhmed]

The button element might not exist during first load when the JS script runs before the DOM element is ready. If new-quote-button doesn't exist when trying to add the event listener, it will result in:

TypeError: Cannot read property 'addEventListener' of null

Please wrap the event listener setup inside window.onload and add a null check:

window.onload = function() {
showRandomQuote();
const button = document.getElementById("new-quote-button");
if (button) {
button.addEventListener("click", showRandomQuote);
}
};

This ensures the DOM is fully loaded before accessing elements and prevents the TypeError.

[A-O-Emmanuel]

Your quote generator app works as intended, but please go through this article 10 Code comments best practices for developers.