generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 193
Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fares-Bakhet
wants to merge
32
commits into
CodeYourFuture:main
Choose a base branch
from
Fares-Bakhet:feature/quotegeneratorapp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
aeabc14
Fix the bug in address.js file
26642e0
Fix the bug in author.js file
ab693e3
Fix the bug in recipe.js file
7105146
Implement a function in contains.js file
19ca88d
Adding tests in contains.test.js file
63b7d45
Implementing a function in lookup.js file
ed3cee8
Adding tests in lookup.test.js file
1babce8
Fix the implement function in querysrting.js file
fd422f1
Adding tests in querystring.test.js file
9279df9
Fix the implement function in tally.js file
1c6ccc3
Adding tests in tally.test.js file
8465e56
Answering questions and fix the implemention and adding tests
81769d1
Adding implementation and test to the file
d5a5bcd
Answering questions
f5a92f8
Answering till.js questions
6d8e6c5
Implementing a alarmclock function
7221a18
Editing file index.html
b6b3f4a
Editing file index.html and quotes.js files
70e0519
Revert "Editing file index.html and quotes.js files"
Fares-Bakhet 5ad1f39
Revert "Editing file index.html"
Fares-Bakhet 413577b
Revert "Implementing a alarmclock function"
Fares-Bakhet 67ecaaa
Revert "Answering till.js questions"
Fares-Bakhet 0939554
Revert "Answering questions"
Fares-Bakhet 0d54919
Revert "Adding implementation and test to the file"
Fares-Bakhet 206b392
Revert "Answering questions and fix the implemention and adding tests"
Fares-Bakhet 75e0482
Revert "Adding tests in tally.test.js file"
Fares-Bakhet 8bb7f6a
Revert "Fix the implement function in tally.js file"
Fares-Bakhet 562022f
Revert "Adding tests in querystring.test.js file"
Fares-Bakhet 62ef964
Revert "Fix the implement function in querysrting.js file"
Fares-Bakhet 5377515
Revert "Adding tests in lookup.test.js file"
Fares-Bakhet 9610268
Revert "Implementing a function in lookup.js file"
Fares-Bakhet a657abb
Fix quotes generator app
Fares-Bakhet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| function contains() {} | ||
| function contains(input, propertyName) { | ||
| if (input && typeof input === 'object' && !Array.isArray(input)) { | ||
| return input.hasOwnProperty(propertyName); | ||
| } | ||
| return false; | ||
|
|
||
| } | ||
|
|
||
| module.exports = contains; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.