Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 14, 2025 12:05
Fares-Bakhet
added
📅 Sprint 3
cjyuan
reviewed
Nov 29, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you revert all unrelated changes made on this branch to keep it clean?
Sprint-3/quote-generator/index.html
Outdated
Comment on lines
10
to
15
| <h1>Quote Generator App</h1> | ||
| <div id="quote-container"> | ||
| <p id="quote-text"></p> | ||
| <p id="quote-author"></p> | ||
| <button id="new-quote-button">New Quote</button> | ||
| </div> |
Author
There was a problem hiding this comment.
@cjyuan, I have reverted all the changes I have made.
Sprint-3/quote-generator/quotes.js
Outdated
Comment on lines
23
to
35
| function showRandomQuote() { | ||
| const randomQuote = pickFromArray(quotes); | ||
| const quoteText = document.getElementById("quote-text"); | ||
| const quoteAuthor = document.getElementById("quote-author"); | ||
|
|
||
| quoteText.innerText = randomQuote.quote; | ||
| quoteAuthor.innerText = `— ${randomQuote.author}`; | ||
| } | ||
|
|
||
| window.onload = showRandomQuote; | ||
|
|
||
| document.getElementById("new-quote-button").addEventListener("click", showRandomQuote); | ||
|
|
Contributor
There was a problem hiding this comment.
We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?
cjyuan
added
Reviewed
Fares-Bakhet
added
Needs Review
cjyuan
reviewed
Dec 1, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Branch is still not clean; it contains some unmodified files in the Sprint-2 folder. Can you make this branch clean?
Comment on lines
8
to
18
| <body> | ||
| <main> | ||
| <section></section> | ||
| <h1>hello there</h1> | ||
| <p id="quote"></p> | ||
| <p id="author"></p> | ||
| <button type="button" id="new-quote">New quote</button> | ||
| </section> | ||
| </main> | ||
| <script defer src="quotes.js"></script> | ||
| </body> |
Contributor
There was a problem hiding this comment.
- Indentation is still off and there seems to be some error in the HTML code.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Editing the JS and HTML files to create a quote generator app.
Questions
No questions.