Skip to content

Glasgow | ITP-SEP-25 | Alaa Tagi | Sprint 3 | feature/alarmclock #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+41 −4
Open

Glasgow | ITP-SEP-25 | Alaa Tagi | Sprint 3 | feature/alarmclock #888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f93276d
implement an alarm function and update title in index.html
Alaa-Tagi Nov 26, 2025
088c50a
fix alarm function as requested
Alaa-Tagi Nov 26, 2025
3b35e29
fix the issue
Alaa-Tagi Dec 1, 2025
0dbf6cd
fix the issue
Alaa-Tagi Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,36 @@
function setAlarm() {}
function setAlarm() {
let time = Number(document.getElementById("alarmSet").value);
const heading = document.getElementById("timeRemaining");

audio.loop = true;

document.body.style.backgroundColor = "";

function updateDisplay(t) {
const minutes = String(Math.floor(t / 60)).padStart(2, "0");
const seconds = String(t % 60).padStart(2, "0");
heading.innerText = `Time Remaining: ${minutes}:${seconds}`;
}
Copy link

@Poonam-raj Poonam-raj Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of modularity to extract updateDisplay behaviour. Could this sit outside of the setAlarm function to further decouple the functions?

Copy link
Author

@Alaa-Tagi Alaa-Tagi Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Poonam-raj i did that .


updateDisplay(time);

const intervalId = setInterval(() => {
time--;

if (time <= 0) {
clearInterval(intervalId);
updateDisplay(0);

document.body.style.backgroundColor = "red";

playAlarm();

} else {
updateDisplay(time);
}
}, 1000);
}


// DO NOT EDIT BELOW HERE

Expand All @@ -22,4 +54,4 @@ function pauseAlarm() {
audio.pause();
}

window.onload = setup;
window.onload = setup;
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down