Glasgow | ITP-SEP-25 | Alaa Tagi | Sprint 3 | feature/alarmclock #888
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alaa-Tagi
added
📅 Sprint 3
Poonam-raj
added
the
Review in progress
Poonam-raj
reviewed
Nov 26, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
9
to
13
| function updateDisplay(t) { | ||
| const minutes = String(Math.floor(t / 60)).padStart(2, "0"); | ||
| const seconds = String(t % 60).padStart(2, "0"); | ||
| heading.innerText = `Time Remaining: ${minutes}:${seconds}`; | ||
| } |
There was a problem hiding this comment.
Good use of modularity to extract updateDisplay behaviour. Could this sit outside of the setAlarm function to further decouple the functions?
Poonam-raj
added
Reviewed
Alaa-Tagi
removed
the
Reviewed
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your alarm clock app works, but the only issues i have is, when i click the set alarm button the alarm goes off even when the input box is empty, that needs to be fixed
A-O-Emmanuel
added
Reviewed
Author
|
@Poonam-raj I fixed the issue where the alarm would start even when the input was empty. |
Alaa-Tagi
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed the tasks required in this sprint.
Questions
No questions.