Skip to content

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Alarm Clock #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Alarm Clock #880

wants to merge 5 commits into from

Conversation

@MohammedNaru
Copy link

@MohammedNaru MohammedNaru commented Nov 23, 2025 •
edited
Loading

Alarm clock Pull Request

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Amended files, added html file to meet task requirements, tests cases are successful.

Questions

No questions for reviewer.

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@MohammedNaru MohammedNaru changed the title Implement alarm functionality and update title in HTML West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 2 | Alarm Clock Nov 23, 2025
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 23, 2025
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@MohammedNaru MohammedNaru changed the title West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 2 | Alarm Clock West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Alarm Clock Nov 23, 2025
@MohammedNaru MohammedNaru added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 23, 2025
bp7968h
bp7968h suggested changes Nov 24, 2025
View reviewed changes
Copy link

@bp7968h bp7968h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work, I have left some comments and there is a bug in your code as well. Please fix those and it should be good to go!

Sprint-3/alarmclock/alarmclock.js Outdated
if (intervalId) clearInterval(intervalId);
remaining = value;
updateHeading();
intervalId = setInterval(tick, 1000);
Copy link

@bp7968h bp7968h Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here 1000 have meaning and these are called magic numbers, explore a bit on handling magic numbers in your code. Would it be more readable if you extract this? How would you do it?

Copy link
Author

@MohammedNaru MohammedNaru Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have implemented these fixes, I have also reviewed magic numbers for this exercise and decided to use a constant instead, please review.

Copy link

@bp7968h bp7968h Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can see your pushed the fixes for minutes and second, however I cannot see the constant on this file for 1000!

Copy link
Author

@MohammedNaru MohammedNaru Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I added it to the wrong sprint I have now reverted that file and committed it now, please review.

@bp7968h bp7968h added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 24, 2025
@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 24, 2025
@bp7968h bp7968h added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 24, 2025
@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 24, 2025
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 24, 2025
JaypeeLan
JaypeeLan reviewed Nov 24, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js Outdated
function format(seconds) {
const minute = String(Math.floor(seconds / 60)).padStart(2, "0");
const second = String(seconds % 60).padStart(2, "0");
return `${minute}:${second}`;
Copy link

@JaypeeLan JaypeeLan Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the timer could be more descriptive. Something like 10m : 22s , because the user is just putting numbers in seconds, and you do the conversion in the background. Then in your HTML input field, use a placeholder to specify the number being inputted, should be in seconds.

@JaypeeLan JaypeeLan removed the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Nov 24, 2025
@JaypeeLan JaypeeLan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Nov 24, 2025
@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 28, 2025
@MohammedNaru MohammedNaru mentioned this pull request Nov 28, 2025
Open
bp7968h
bp7968h approved these changes Nov 29, 2025
View reviewed changes
Copy link

@bp7968h bp7968h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MohammedNaru MohammedNaru added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaypeeLan JaypeeLan Awaiting requested review from JaypeeLan

1 more reviewer

@bp7968h bp7968h bp7968h approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MohammedNaru @JaypeeLan @bp7968h