Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Sprint-3/dead-code/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Refactoring Dead Code

Here are two example of code that has not been built efficiently. Both files have dead code in them, it's your job to go back through this existing code, identify the dead code, and remove it so the code is ready for production.

## Instructions

1. Work through each `exercise` file inside this directory.
2. Delete the dead code.
3. Commit your changes and make a PR when done.
16 changes: 16 additions & 0 deletions Sprint-3/dead-code/exercise-1.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Find the instances of unreachable and redundant code - remove them!

let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);

console.log(greetingMessage); // 'hello, Aman!'
27 changes: 27 additions & 0 deletions Sprint-3/dead-code/exercise-2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Remove the unused code that does not contribute to the final console log

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};

petsArr.forEach((pet) => {
const capitalisedPet = pet.toUpperCase();
if (petCount[capitalisedPet]) {
petCount[capitalisedPet] += 1;
} else {
petCount[capitalisedPet] = 1;
}
});
return petCount;
}

const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log