Skip to content

NW | 25-ITP-Sep | TzeMing Ho | Sprint 2 | book-library-debugging #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

NW | 25-ITP-Sep | TzeMing Ho | Sprint 2 | book-library-debugging #326

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b926cf
completed book-library debugging
TzeMingHo Nov 3, 2025
3ccacab
After reading feedback, some improvement
TzeMingHo Nov 12, 2025
34fe6f0
updated branch name
TzeMingHo Nov 12, 2025
64e5908
took the eventhandler off from html, and trim pagesValue
TzeMingHo Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<title>Virtual library</title>
<meta charset="utf-8" />
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
Expand All @@ -28,18 +28,18 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<form class="form-group" id="book-form" onsubmit="handleSubmit(event)" >
Copy link
Contributor

@cjyuan cjyuan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider attaching event handler to the form in JS (to keep HTML code free of JS code)

Copy link
Author

@TzeMingHo TzeMingHo Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have removed the function from the HTML and created an eventListener in the script.

<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -51,6 +51,7 @@ <h1>Library</h1>
class="form-control"
id="pages"
name="pages"
min="1"
required
/>
<label class="form-check-label">
Expand All @@ -65,9 +66,8 @@ <h1>Library</h1>
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
</form>
</div>

<table class="table" id="display">
Expand All @@ -80,17 +80,11 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tbody id="display-body">

</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" defer></script>
Copy link
Contributor

@cjyuan cjyuan Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Consider loading script.js as an ES module to isolate its scope from the global context:

<script src="script.js" type="module"></script>

This ensures that variables, functions, and imports in script.js don’t leak into the global namespace, helps prevent naming conflicts, and enables the use of modern JavaScript features like import and export.

  • Also, with type="module", defer is automatically enforced.

Copy link
Author

@TzeMingHo TzeMingHo Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is something useful. Good to know.

</body>
</html>
98 changes: 48 additions & 50 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@ let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,84 +19,83 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
function handleSubmit(event) {
event.preventDefault();
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
!titleInput.value.trim() ||
!authorInput.value.trim() ||
pagesInput.value <= 0
Copy link
Contributor

@cjyuan cjyuan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some "weird" numbers (that shouldn't be considered valid page count) could still pass this check. Can you figure out what these numbers are and "handle" them appropriately?

Copy link
Author

@TzeMingHo TzeMingHo Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best to think of the weird numbers could be some spaces before or after the actual numbers. I added a trim process for the pages value as well. I hope this will help prevent some strange situations.

) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(String(titleInput.value), String(authorInput.value), Number(pagesInput.value), checkInput.checked);
Copy link
Contributor

@cjyuan cjyuan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.value is always a string. And on line 39, they could still contain leading or trailing spaces.

myLibrary.push(book);
resetAddNewBook()
render();
}
}

function Book(title, author, pages, check) {
function resetAddNewBook() {
document.getElementById("book-form").reset()
}

class Book {
constructor (title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
let tableBody = document.getElementById("display-body")
Copy link
Contributor

@cjyuan cjyuan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider (in code refactoring stage) change let to const for all variables that are not going to be reassigned a value.

tableBody.innerHTML = '';
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
myLibrary.forEach((book, index) => {
let row = tableBody.insertRow(-1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.innerText = book.title;
authorCell.innerText = book.author;
pagesCell.innerText = book.pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
//add and wait for action for readToggle button
let readToggleButton = document.createElement("button");
readToggleButton.id = `readOrUnreadBtn${index}`;
readToggleButton.className = "btn btn-success";
wasReadCell.appendChild(readToggleButton);

readToggleButton.innerText = book.check ? "Yes" : "No";

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
readToggleButton.addEventListener("click", function () {
book.check = !book.check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
let deleteButton = document.createElement("button");
deleteButton.id = `delBtn${index}`;
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.innerText = "Delete";
deleteButton.addEventListener("click", () => {
if (confirm(`You've deleted title: ${book.title}`)) {
myLibrary.splice(index, 1);
render();
}
});
}
})
}