From 1b926cff1e3fcc9ba4ddde32e16b4127d922beb1 Mon Sep 17 00:00:00 2001
From: TzeMingHo <tzemingho@gmail.com>
Date: Mon, 3 Nov 2025 17:46:06 +0000
Subject: [PATCH 1/4] completed book-library debugging

---
 debugging/book-library/index.html |  3 +-
 debugging/book-library/script.js  | 63 +++++++++++++++++--------------
 2 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 23acfa71..2a4ce9ed 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -51,6 +51,7 @@ <h1>Library</h1>
           class="form-control"
           id="pages"
           name="pages"
+          min="1"
           required
         />
         <label class="form-check-label">
@@ -91,6 +92,6 @@ <h1>Library</h1>
       </tbody>
     </table>
 
-    <script src="script.js"></script>
+    <script src="script.js" defer></script>
   </body>
 </html>
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index 75ce6c1d..0a6b4480 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -7,7 +7,7 @@ window.addEventListener("load", function (e) {
 
 function populateStorage() {
   if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
+    let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
     let book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
@@ -29,20 +29,27 @@ const check = document.getElementById("check");
 //via Book function and start render function
 function submit() {
   if (
-    title.value == null ||
-    title.value == "" ||
-    pages.value == null ||
-    pages.value == ""
+    !title.value.trim() ||
+    !author.value.trim() ||
+    !pages.value
   ) {
     alert("Please fill all fields!");
     return false;
   } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
+    let book = new Book(title.value, author.value, pages.value, check.checked);
+    myLibrary.push(book);
+    resetAddNewBook()
     render();
   }
 }
 
+function resetAddNewBook() {
+  title.value = '';
+  author.value = '';
+  pages.value = '';
+  check.checked = false;
+}
+
 function Book(title, author, pages, check) {
   this.title = title;
   this.author = author;
@@ -54,49 +61,49 @@ function render() {
   let table = document.getElementById("display");
   let rowsNumber = table.rows.length;
   //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
+  for (let n = rowsNumber - 1; n > 0; n-- ){
     table.deleteRow(n);
   }
   //insert updated row and cells
   let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
+  for (let libraryBookIndex = 0; libraryBookIndex < length; libraryBookIndex++) {
+    let row = table.insertRow(-1);
     let titleCell = row.insertCell(0);
     let authorCell = row.insertCell(1);
     let pagesCell = row.insertCell(2);
     let wasReadCell = row.insertCell(3);
     let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[i].title;
-    authorCell.innerHTML = myLibrary[i].author;
-    pagesCell.innerHTML = myLibrary[i].pages;
+    titleCell.innerHTML = myLibrary[libraryBookIndex].title;
+    authorCell.innerHTML = myLibrary[libraryBookIndex].author;
+    pagesCell.innerHTML = myLibrary[libraryBookIndex].pages;
 
     //add and wait for action for read/unread button
-    let changeBut = document.createElement("button");
-    changeBut.id = i;
-    changeBut.className = "btn btn-success";
-    wasReadCell.appendChild(changeBut);
+    let readOrUnreadButton = document.createElement("button");
+    readOrUnreadButton.id = `readOrUnreadBtn${libraryBookIndex}`;
+    readOrUnreadButton.className = "btn btn-success";
+    wasReadCell.appendChild(readOrUnreadButton);
     let readStatus = "";
-    if (myLibrary[i].check == false) {
+    if (myLibrary[libraryBookIndex].check) {
       readStatus = "Yes";
     } else {
       readStatus = "No";
     }
-    changeBut.innerText = readStatus;
+    readOrUnreadButton.innerText = readStatus;
 
-    changeBut.addEventListener("click", function () {
-      myLibrary[i].check = !myLibrary[i].check;
+    readOrUnreadButton.addEventListener("click", function () {
+      myLibrary[libraryBookIndex].check = !myLibrary[libraryBookIndex].check;
       render();
     });
 
     //add delete button to every row and render again
     let delButton = document.createElement("button");
-    delBut.id = i + 5;
-    deleteCell.appendChild(delBut);
-    delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
-      alert(`You've deleted title: ${myLibrary[i].title}`);
-      myLibrary.splice(i, 1);
+    delButton.id = `delBtn${libraryBookIndex}`;
+    deleteCell.appendChild(delButton);
+    delButton.className = "btn btn-warning";
+    delButton.innerHTML = "Delete";
+    delButton.addEventListener("click", () => {
+      alert(`You've deleted title: ${myLibrary[libraryBookIndex].title}`);
+      myLibrary.splice(libraryBookIndex, 1);
       render();
     });
   }

From 3ccacab391c19a4ca06cfc30c99e66b30f9a275c Mon Sep 17 00:00:00 2001
From: TzeMingHo <tzemingho@gmail.com>
Date: Wed, 12 Nov 2025 13:06:26 +0000
Subject: [PATCH 2/4] After reading feedback, some improvement

---
 debugging/book-library/index.html | 23 +++----
 debugging/book-library/script.js  | 99 +++++++++++++++----------------
 2 files changed, 55 insertions(+), 67 deletions(-)

diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 2a4ce9ed..076fa555 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -1,9 +1,9 @@
 <!DOCTYPE html>
 <html>
   <head>
-    <title> </title>
+    <title>Virtual library</title>
+    <meta charset="utf-8" />
     <meta
-      charset="utf-8"
       name="viewport"
       content="width=device-width, initial-scale=1.0"
     />
@@ -28,10 +28,10 @@ <h1>Library</h1>
     </button>
 
     <div id="demo" class="collapse">
-      <div class="form-group">
+      <form class="form-group" id="book-form" onsubmit="handleSubmit(event)" >
         <label for="title">Title:</label>
         <input
-          type="title"
+          type="text"
           class="form-control"
           id="title"
           name="title"
@@ -39,7 +39,7 @@ <h1>Library</h1>
         />
         <label for="author">Author: </label>
         <input
-          type="author"
+          type="text"
           class="form-control"
           id="author"
           name="author"
@@ -66,9 +66,8 @@ <h1>Library</h1>
           type="submit"
           value="Submit"
           class="btn btn-primary"
-          onclick="submit();"
         />
-      </div>
+      </form>
     </div>
 
     <table class="table" id="display">
@@ -81,14 +80,8 @@ <h1>Library</h1>
           <th></th>
         </tr>
       </thead>
-      <tbody>
-        <tr>
-          <td></td>
-          <td></td>
-          <td></td>
-          <td></td>
-          <td></td>
-        </tr>
+      <tbody id="display-body">
+        
       </tbody>
     </table>
 
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index 0a6b4480..be8eb60b 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -2,16 +2,15 @@ let myLibrary = [];
 
 window.addEventListener("load", function (e) {
   populateStorage();
-  render();
 });
 
 function populateStorage() {
   if (myLibrary.length == 0) {
-    let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
+    let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
     let book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
-      "127",
+      127,
       true
     );
     myLibrary.push(book1);
@@ -20,23 +19,24 @@ function populateStorage() {
   }
 }
 
-const title = document.getElementById("title");
-const author = document.getElementById("author");
-const pages = document.getElementById("pages");
-const check = document.getElementById("check");
+const titleInput = document.getElementById("title");
+const authorInput = document.getElementById("author");
+const pagesInput = document.getElementById("pages");
+const checkInput = document.getElementById("check");
 
 //check the right input from forms and if its ok -> add the new book (object in array)
 //via Book function and start render function
-function submit() {
+function handleSubmit(event) {
+  event.preventDefault();
   if (
-    !title.value.trim() ||
-    !author.value.trim() ||
-    !pages.value
+    !titleInput.value.trim() ||
+    !authorInput.value.trim() ||
+    pagesInput.value <= 0
   ) {
     alert("Please fill all fields!");
     return false;
   } else {
-    let book = new Book(title.value, author.value, pages.value, check.checked);
+    let book = new Book(String(titleInput.value), String(authorInput.value), Number(pagesInput.value), checkInput.checked);
     myLibrary.push(book);
     resetAddNewBook()
     render();
@@ -44,67 +44,62 @@ function submit() {
 }
 
 function resetAddNewBook() {
-  title.value = '';
-  author.value = '';
-  pages.value = '';
-  check.checked = false;
+  // titleInput.value = '';
+  // authorInput.value = '';
+  // pagesInput.value = 0;
+  // checkInput.checked = false;
+  document.getElementById("book-form").reset()
 }
 
-function Book(title, author, pages, check) {
+class Book {
+  constructor (title, author, pages, check) {
   this.title = title;
   this.author = author;
   this.pages = pages;
   this.check = check;
+  }
 }
 
 function render() {
-  let table = document.getElementById("display");
-  let rowsNumber = table.rows.length;
   //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- ){
-    table.deleteRow(n);
-  }
+  let tableBody = document.getElementById("display-body")
+  tableBody.innerHTML = '';
   //insert updated row and cells
-  let length = myLibrary.length;
-  for (let libraryBookIndex = 0; libraryBookIndex < length; libraryBookIndex++) {
-    let row = table.insertRow(-1);
+  myLibrary.forEach((book, index) => {
+    let row = tableBody.insertRow(-1);
     let titleCell = row.insertCell(0);
     let authorCell = row.insertCell(1);
     let pagesCell = row.insertCell(2);
     let wasReadCell = row.insertCell(3);
     let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[libraryBookIndex].title;
-    authorCell.innerHTML = myLibrary[libraryBookIndex].author;
-    pagesCell.innerHTML = myLibrary[libraryBookIndex].pages;
+    titleCell.innerText = book.title;
+    authorCell.innerText = book.author;
+    pagesCell.innerText = book.pages;
 
-    //add and wait for action for read/unread button
-    let readOrUnreadButton = document.createElement("button");
-    readOrUnreadButton.id = `readOrUnreadBtn${libraryBookIndex}`;
-    readOrUnreadButton.className = "btn btn-success";
-    wasReadCell.appendChild(readOrUnreadButton);
-    let readStatus = "";
-    if (myLibrary[libraryBookIndex].check) {
-      readStatus = "Yes";
-    } else {
-      readStatus = "No";
-    }
-    readOrUnreadButton.innerText = readStatus;
+    //add and wait for action for readToggle button
+    let readToggleButton = document.createElement("button");
+    readToggleButton.id = `readOrUnreadBtn${index}`;
+    readToggleButton.className = "btn btn-success";
+    wasReadCell.appendChild(readToggleButton);
+    
+    readToggleButton.innerText = book.check ? "Yes" : "No";
 
-    readOrUnreadButton.addEventListener("click", function () {
-      myLibrary[libraryBookIndex].check = !myLibrary[libraryBookIndex].check;
+    readToggleButton.addEventListener("click", function () {
+      book.check = !book.check;
       render();
     });
 
     //add delete button to every row and render again
-    let delButton = document.createElement("button");
-    delButton.id = `delBtn${libraryBookIndex}`;
-    deleteCell.appendChild(delButton);
-    delButton.className = "btn btn-warning";
-    delButton.innerHTML = "Delete";
-    delButton.addEventListener("click", () => {
-      alert(`You've deleted title: ${myLibrary[libraryBookIndex].title}`);
-      myLibrary.splice(libraryBookIndex, 1);
-      render();
+    let deleteButton = document.createElement("button");
+    deleteButton.id = `delBtn${index}`;
+    deleteCell.appendChild(deleteButton);
+    deleteButton.className = "btn btn-warning";
+    deleteButton.innerText = "Delete";
+    deleteButton.addEventListener("click", () => {
+      if (confirm(`You've deleted title: ${book.title}`)) {
+        myLibrary.splice(index, 1);
+        render();
+      }
     });
-  }
+  })
 }

From 34fe6f0b9f1b7042cd11c8e6342f6ccf3196deea Mon Sep 17 00:00:00 2001
From: TzeMingHo <tzemingho@gmail.com>
Date: Wed, 12 Nov 2025 13:19:13 +0000
Subject: [PATCH 3/4] updated branch name

---
 debugging/book-library/script.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index be8eb60b..b82c0573 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -44,10 +44,6 @@ function handleSubmit(event) {
 }
 
 function resetAddNewBook() {
-  // titleInput.value = '';
-  // authorInput.value = '';
-  // pagesInput.value = 0;
-  // checkInput.checked = false;
   document.getElementById("book-form").reset()
 }
 

From 64e59089a03669732954f52513dd3634df9a46bf Mon Sep 17 00:00:00 2001
From: TzeMingHo <tzemingho@gmail.com>
Date: Thu, 13 Nov 2025 15:24:39 +0000
Subject: [PATCH 4/4] took the eventhandler off from html, and trim pagesValue

---
 debugging/book-library/index.html |  2 +-
 debugging/book-library/script.js  | 20 ++++++++++++++------
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 076fa555..bfd1c7cb 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -28,7 +28,7 @@ <h1>Library</h1>
     </button>
 
     <div id="demo" class="collapse">
-      <form class="form-group" id="book-form" onsubmit="handleSubmit(event)" >
+      <form class="form-group" id="book-form">
         <label for="title">Title:</label>
         <input
           type="text"
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index b82c0573..9c877ee5 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -28,21 +28,29 @@ const checkInput = document.getElementById("check");
 //via Book function and start render function
 function handleSubmit(event) {
   event.preventDefault();
+  let titleValue = titleInput.value.trim();
+  let authorValue = authorInput.value.trim();
+  let pagesValue = Number(pagesInput.value.trim());
+  let read = checkInput.checked;
   if (
-    !titleInput.value.trim() ||
-    !authorInput.value.trim() ||
-    pagesInput.value <= 0
+    !titleValue||
+    !authorValue ||
+    !Number.isInteger(pagesValue) ||
+    Number(pagesValue) <= 0 
   ) {
-    alert("Please fill all fields!");
+    alert("Please fill all fields! Page count must be a whole number above 0.");
     return false;
   } else {
-    let book = new Book(String(titleInput.value), String(authorInput.value), Number(pagesInput.value), checkInput.checked);
+    let book = new Book(titleValue, authorValue, pagesValue, read);
     myLibrary.push(book);
     resetAddNewBook()
     render();
   }
 }
 
+const bookForm = document.getElementById("book-form")
+bookForm.addEventListener("submit", (event) => handleSubmit(event));
+
 function resetAddNewBook() {
   document.getElementById("book-form").reset()
 }
@@ -58,7 +66,7 @@ class Book {
 
 function render() {
   //delete old table
-  let tableBody = document.getElementById("display-body")
+  const tableBody = document.getElementById("display-body")
   tableBody.innerHTML = '';
   //insert updated row and cells
   myLibrary.forEach((book, index) => {