Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-1/destructuring/exercise-1/exercise.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const personOne = {

// Update the parameter to this function to make it work.
// Don't change anything else.
function introduceYourself(___________________________) {
function introduceYourself({name, age, favouriteFood}) {
console.log(
`Hello, my name is ${name}. I am ${age} years old and my favourite food is ${favouriteFood}.`
);
Expand Down
16 changes: 16 additions & 0 deletions Sprint-1/destructuring/exercise-2/exercise.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,19 @@ let hogwarts = [
occupation: "Teacher",
},
];


function gryffindorHouse(hogwarts) {
return hogwarts.filter(({house}) => house === 'Gryffindor').map(({firstName, lastName}) => `${firstName} ${lastName}`).join("\n")
}

function teachersWithPets(hogwarts) {
return hogwarts.reduce((nameList, {firstName, lastName, pet, occupation}) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd similarly recommend a filter and map here :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have updated the function teachersWithPets as well.

if (occupation === "Teacher" && pet !== null) {
nameList.push(`${firstName} ${lastName}`)
}
return nameList;
}, []).join("\n")
}

console.log(gryffindorHouse(hogwarts));
30 changes: 30 additions & 0 deletions Sprint-1/destructuring/exercise-3/exercise.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,33 @@ let order = [
{ itemName: "Hot Coffee", quantity: 2, unitPricePence: 100 },
{ itemName: "Hash Brown", quantity: 4, unitPricePence: 40 },
];


function receiptAndCosts(order) {
let total = 0;

let receipt = []

function orderLineFormatting(...args) {
const orderLineSpacing = [8, 20, 5]
let formattedOrderLine = ''
for (let index = 0; index < args.length; index++) {
formattedOrderLine += `${String(args[index]).padEnd(orderLineSpacing[index], " ")}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute use of args!

One disadvantage of using ...args is it makes it less clear to someone trying to use your function what arguments it actually expects. I'd recommend adding a check at the start of the function which checks the right number of args was passed (and throws if not), and maybe also a documentation comment explaining what's expected and in which order.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would an error message when the length of arguments is not equal to 3 be good enough for users?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think that'd be sufficient :) (don't forget the comment for the function!)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a comment for the function.

}
return formattedOrderLine
}

receipt.push(orderLineFormatting("QTY", "ITEM", "TOTAL"));

order.forEach(({itemName, quantity, unitPricePence}) => {
const subTotal = (unitPricePence / 100 * quantity).toFixed(2)
receipt.push(orderLineFormatting(quantity, itemName, subTotal))
total += unitPricePence / 100 * quantity
})

receipt.push(" ")
receipt.push(`Total: ${total.toFixed(2)}`)
return receipt.join("\n")
}

console.log(receiptAndCosts(order))