From c038a0f1b8fa652753cc7c46826ed9e7325a9ed6 Mon Sep 17 00:00:00 2001 From: mervereis Date: Tue, 13 Oct 2026 22:06:37 +0100 Subject: [PATCH 1/2] Refactor find_longest_common_prefix for clarity and efficiency --- .../common_prefix/common_prefix.py | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py index f4839e70..5e59354c 100644 --- a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py +++ b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py @@ -1,24 +1,28 @@ from typing import List -def find_longest_common_prefix(strings: List[str]): - """ - find_longest_common_prefix returns the longest string common at the start of any two strings in the passed list. +def find_longest_common_prefix(strings: List[str]) -> str: + if len(strings) < 2: + return "" + + strings = sorted(strings) - In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned. - """ longest = "" - for string_index, string in enumerate(strings): - for other_string in strings[string_index+1:]: - common = find_common_prefix(string, other_string) - if len(common) > len(longest): - longest = common + + for i in range(len(strings) - 1): + common = find_common_prefix(strings[i], strings[i + 1]) + + if len(common) > len(longest): + longest = common + return longest def find_common_prefix(left: str, right: str) -> str: min_length = min(len(left), len(right)) + for i in range(min_length): if left[i] != right[i]: return left[:i] + return left[:min_length] From 094afd75e2b49d1fd6869822e76a90f69f73839a Mon Sep 17 00:00:00 2001 From: mervereis Date: Tue, 13 Oct 2026 22:09:29 +0100 Subject: [PATCH 2/2] Refactor count_letters for improved clarity and efficiency --- .../count_letters/count_letters.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index 62c3ec07..082e8261 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -1,14 +1,13 @@ def count_letters(s: str) -> int: - """ - count_letters returns the number of letters which only occur in upper case in the passed string. - """ - only_upper = set() + upper = set() + lower = set() + for letter in s: - if is_upper_case(letter): - if letter.lower() not in s: - only_upper.add(letter) - return len(only_upper) + if letter.isupper(): + upper.add(letter) + elif letter.islower(): + lower.add(letter) + only_upper = upper - {letter.upper() for letter in lower} -def is_upper_case(letter: str) -> bool: - return letter == letter.upper() + return len(only_upper) \ No newline at end of file