Merge pull request #247 from CodeForPhilly/246-clean-ui-warnings

Cleanups and overrides to eliminate npm warnings

Author: c-simpson

src/client/src/App.js

@@ -1,7 +1,6 @@
 import React from 'react'
 
 import {BrowserRouter as Router, Switch, Route} from 'react-router-dom';
-
 import Header, {AdminHeader} from "./components/Header";
 
 import HomePage from './pages/Home';
@@ -71,7 +70,7 @@ function AuthenticatedApp() {
 
 
     var decoded = jwt.decode(access_token, { complete: true });
-    const userName = decoded?.payload.sub;
+    
     const userRole = decoded?.payload.role;
     var expTime =  decoded?.payload.exp -  Date.now()/1000;
 
@@ -123,13 +122,13 @@ function AuthenticatedApp() {
 
 function Home() {
   const {user} = useAuthState()
+  /*eslint no-unused-vars: ["warn", { "varsIgnorePattern": "access_token" }]*/
   const { access_token, setToken } = useToken();
   return user ? <AuthenticatedApp /> : <Login setToken={setToken} />
 }
 
 function App() {
-  const { access_token, setToken } = useToken();
-
+ 
   return (
     <AuthProvider>
       <div>

src/client/src/pages/Check/Check.js

@@ -16,44 +16,7 @@ export default function Check() {
 
     let history = useHistory()
 
-    function authCheck() {
-     //   console.log('authCheck startfetch @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
-        fetch('http://localhost:5000/api/user/test_auth',
-        {
-            method: 'GET',
-            headers: {
-                'Content-Type': 'application/json',
-                'Authorization': 'Bearer ' + access_token
-            }
-        })
-    
-        .then((response) => {
-         //   console.log('authCheck handle response @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
-            if (!response.ok) {
-                //throw (String(response.status + ':' + response.statusText))
-                throw (response)
-            }
-            return response.json()
-        } )
-        .then((data) => {
-          //  console.log('authCheck data  @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
-            setProcessStatus('complete');
-            setData(data);
-        })
-        .catch((e) => {
-            let errCode = e.status
-            let errText = e.statusText
-    
-            setToken(null)  // Clear the token to force login again
-            let errStr = String(e)
-            setProcessStatus('error');
-            setError(errStr);
-            console.log(errCode + ':' + errText)
-            history.push('/')
-            return e
-        });
-    
-    }  // 
+     
 
 
 
@@ -68,6 +31,59 @@ export default function Check() {
 
     React.useEffect(() => {
 
+
+
+        function authCheck() {
+            //   console.log('authCheck startfetch @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
+               fetch('http://localhost:5000/api/user/test_auth',
+               {
+                   method: 'GET',
+                   headers: {
+                       'Content-Type': 'application/json',
+                       'Authorization': 'Bearer ' + access_token
+                   }
+               })
+           
+               .then((response) => {
+                //   console.log('authCheck handle response @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
+                   if (!response.ok) {
+                       //throw (String(response.status + ':' + response.statusText))
+                       throw (response)
+                   }
+                   return response.json()
+               } )
+               .then((data) => {
+                 //  console.log('authCheck data  @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
+                   setProcessStatus('complete');
+                   setData(data);
+               })
+               .catch((e) => {
+                   let errCode = e.status
+                   let errText = e.statusText
+           
+                   setToken(null)  // Clear the token to force login again
+                   let errStr = String(e)
+                   setProcessStatus('error');
+                   setError(errStr);
+                   console.log(errCode + ':' + errText)
+                   history.push('/')
+                   return e
+               });
+           
+           }  //
+
+
+
+
+
+
+
+
+
+
+
+
+
         if (! access_token){
            console.log("In Check w/o a token")
         }
@@ -77,7 +93,9 @@ export default function Check() {
    //  console.log('After authCheck @ ' + DateTime.local().toFormat('HH:mm:ss.SSS'))
 
 
-    }, [ processStatus, access_token]);
+    }, 
+    // eslint-disable-next-line 
+    [ processStatus, access_token, history ]);
 
     // if (processStatus === 'loading') {
     //     console.log('Check: if pc=l loading...')