From 5173e7495e5477011d3311ed6587c8c8293b00c0 Mon Sep 17 00:00:00 2001 From: Amp Date: Sun, 15 Nov 2026 03:39:22 +0000 Subject: [PATCH] refactor(io): move object identity cache key into its implementation Exercise CodeBoarding v1.19.2 review analysis with a behavior-preserving C++ method relocation. Amp-Thread-ID: https://ampcode.com/threads/T-01a1dd41-1aad-7416-8e56-cd11369c1910 Co-authored-by: Ivan Milev --- include/cucascade/io/object_identity.hpp | 20 +------------------- src/io/object_identity.cpp | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/include/cucascade/io/object_identity.hpp b/include/cucascade/io/object_identity.hpp index 7c06848e..ca7632a8 100644 --- a/include/cucascade/io/object_identity.hpp +++ b/include/cucascade/io/object_identity.hpp @@ -53,25 +53,7 @@ struct object_identity { /// A key naming this identity of the object at @p locator. The length /// prefix makes arbitrary paths and tags unambiguous; an ETag is never parsed. - [[nodiscard]] std::string cache_key(std::string_view locator) const - { - std::string key = std::to_string(locator.size()); - key.push_back(':'); - key.append(locator); - key.push_back(':'); - key.append(std::to_string(static_cast(kind))); - key.push_back(':'); - key.append(std::to_string(size)); - key.push_back(':'); - key.append(std::to_string(device)); - key.push_back(':'); - key.append(std::to_string(inode)); - key.push_back(':'); - key.append(std::to_string(ctime_ns)); - key.push_back(':'); - key.append(version); - return key; - } + [[nodiscard]] std::string cache_key(std::string_view locator) const; }; /// A process-wide, strictly increasing number for each opened object (never 0): diff --git a/src/io/object_identity.cpp b/src/io/object_identity.cpp index cc6a6efe..fc87425a 100644 --- a/src/io/object_identity.cpp +++ b/src/io/object_identity.cpp @@ -23,6 +23,26 @@ namespace cucascade::io { +std::string object_identity::cache_key(std::string_view locator) const +{ + std::string key = std::to_string(locator.size()); + key.push_back(':'); + key.append(locator); + key.push_back(':'); + key.append(std::to_string(static_cast(kind))); + key.push_back(':'); + key.append(std::to_string(size)); + key.push_back(':'); + key.append(std::to_string(device)); + key.push_back(':'); + key.append(std::to_string(inode)); + key.push_back(':'); + key.append(std::to_string(ctime_ns)); + key.push_back(':'); + key.append(version); + return key; +} + std::uint64_t next_open_generation() noexcept { // Defined here, not inline in the header: every module linking cucascade_io