Close connection to server on GOODBYE

darkl · darkl · commit 233e97940924 · 2017-10-18T11:37:08.000-04:00
As some routers (crossbar.io) don't do this.
diff --git a/src/net45/WampSharp/WAMP2/V2/Client/Session/WampSessionClient.cs b/src/net45/WampSharp/WAMP2/V2/Client/Session/WampSessionClient.cs
@@ -114,10 +114,8 @@ public void Goodbye(GoodbyeDetails details, string reason)
             {
                 mServerProxy.Goodbye(new GoodbyeDetails(), WampErrors.GoodbyeAndOut);
             }
-            else
-            {
-                mServerProxy.Dispose();
-            }
+
+            mServerProxy.Dispose();
 
             TrySetCloseEventArgs(SessionCloseType.Goodbye, details, reason);
         }

Original file line number	Diff line number	Diff line change
`@@ -114,10 +114,8 @@ public void Goodbye(GoodbyeDetails details, string reason)`
`114`	`114`	`{`
`115`	`115`	`mServerProxy.Goodbye(new GoodbyeDetails(), WampErrors.GoodbyeAndOut);`
`116`	`116`	`}`
`117`		`- else`
`118`		`- {`
`119`		`- mServerProxy.Dispose();`
`120`		`- }`
	`117`	`+`
	`118`	`+ mServerProxy.Dispose();`
`121`	`119`
`122`	`120`	`TrySetCloseEventArgs(SessionCloseType.Goodbye, details, reason);`
`123`	`121`	`}`