Changed error report behavior

Now ABORT and GOODBYE are reported upon disconnection and not before.
This solves some issues with the reconnector mechanism.

Author: Elad Zelingher

src/net45/WampSharp/WAMP2/V2/Client/Session/WampSessionClient.cs

@@ -27,6 +27,7 @@ public class WampSessionClient<TMessage> : IWampSessionClientExtended,
         private HelloDetails mSentDetails;
 
         private int mIsConnected = 0;
+        private WampSessionCloseEventArgs mCloseEventArgs;
 
         private static HelloDetails GetDetails()
         {
@@ -98,7 +99,7 @@ public void Welcome(long session, WelcomeDetails details)
 
         public void Abort(AbortDetails details, string reason)
         {
-            RaiseConnectionBroken(SessionCloseType.Abort, details, reason);
+            TrySetCloseEventArgs(SessionCloseType.Abort, details, reason);
         }
 
         public void Goodbye(GoodbyeDetails details, string reason)
@@ -108,34 +109,34 @@ public void Goodbye(GoodbyeDetails details, string reason)
                 mServerProxy.Goodbye(new GoodbyeDetails(), WampErrors.GoodbyeAndOut);
             }
 
-            RaiseConnectionBroken(SessionCloseType.Goodbye, details, reason);
+            TrySetCloseEventArgs(SessionCloseType.Goodbye, details, reason);
         }
 
-        private void RaiseConnectionBroken(SessionCloseType sessionCloseType, GoodbyeAbortDetails details, string reason)
+        private void RaiseConnectionBroken()
         {
-            bool connectionBrokenRaised = mConnectionBrokenRaised;
+            TrySetCloseEventArgs(SessionCloseType.Disconnection);
 
-            mConnectionBrokenRaised = true;
+            WampSessionCloseEventArgs closeEventArgs = mCloseEventArgs;
 
-            WampSessionCloseEventArgs closeEventArgs = new WampSessionCloseEventArgs
-                (sessionCloseType, mSession,
-                    details,
-                    reason);
-
-            SetOpenTaskErrorIfNeeded(new WampConnectionBrokenException(closeEventArgs));
+            SetOpenTaskErrorIfNeeded(new WampConnectionBrokenException(mCloseEventArgs));
 
-            if (sessionCloseType == SessionCloseType.Disconnection)
-            {
-                Interlocked.CompareExchange(ref mIsConnected, 0, 1);
+            Interlocked.CompareExchange(ref mIsConnected, 0, 1);
+            mOpenTask = new TaskCompletionSource<bool>();
+            mCloseEventArgs = null;
 
-                mOpenTask = new TaskCompletionSource<bool>();
-
-                mConnectionBrokenRaised = false;
-            }
+            OnConnectionBroken(closeEventArgs);
+        }
 
-            if (!connectionBrokenRaised)
+        private void TrySetCloseEventArgs(SessionCloseType sessionCloseType,
+                                          GoodbyeAbortDetails details = null,
+                                          string reason = null)
+        {
+            if (mCloseEventArgs == null)
             {
-                OnConnectionBroken(closeEventArgs);
+                mCloseEventArgs = new WampSessionCloseEventArgs
+                (sessionCloseType, mSession,
+                 details,
+                 reason);
             }
         }
 
@@ -195,11 +196,7 @@ public void OnConnectionOpen()
 
         public void OnConnectionClosed()
         {
-            SetOpenTaskErrorIfNeeded(new Exception("Connection closed before connection established."));
-
-            RaiseConnectionBroken(SessionCloseType.Disconnection,
-                                  null,
-                                  null);
+            RaiseConnectionBroken();
         }
 
         public void OnConnectionError(Exception exception)