nit

Author: pan3793

spark-3.4/clickhouse-spark-it/src/test/scala/org/apache/spark/sql/clickhouse/cluster/ClusterShardByTransformSuite.scala

@@ -18,11 +18,8 @@ import org.apache.spark.SparkConf
 import org.apache.spark.sql.Row
 
 class ClusterShardByTransformSuite extends SparkClickHouseClusterTest {
-  override protected def sparkConf: SparkConf = {
-    val _conf = super.sparkConf
-      .set("spark.clickhouse.write.distributed.convertLocal", "true")
-    _conf
-  }
+  override protected def sparkConf: SparkConf = super.sparkConf
+    .set("spark.clickhouse.write.distributed.convertLocal", "true")
 
   def runTest(func_name: String, func_args: Array[String]): Unit = {
     val func_expr = s"$func_name(${func_args.mkString(",")})"
@@ -94,13 +91,13 @@ class ClusterShardByTransformSuite extends SparkClickHouseClusterTest {
   }
 
   Seq(
-    // wait for SPARK-44180 to be fixed, then add implicit cast test cases
+    // TODO timezone aware implicit cast requires SPARK-44180
     ("toYear", Array("create_date")),
-//    ("toYear", Array("create_time")),
+    // ("toYear", Array("create_time")),
     ("toYYYYMM", Array("create_date")),
-//    ("toYYYYMM", Array("create_time")),
+    // ("toYYYYMM", Array("create_time")),
     ("toYYYYMMDD", Array("create_date")),
-//    ("toYYYYMMDD", Array("create_time")),
+    // ("toYYYYMMDD", Array("create_time")),
     ("toHour", Array("create_time")),
     ("xxHash64", Array("value")),
     ("murmurHash2_64", Array("value")),

spark-3.4/clickhouse-spark/src/main/scala/xenon/clickhouse/func/Days.scala

@@ -34,7 +34,8 @@ object Days extends UnboundFunction with ScalarFunction[Int] with ClickhouseEqui
 
   override def bind(inputType: StructType): BoundFunction = inputType.fields match {
     case Array(StructField(_, DateType, _, _)) => this
-//    case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
+    // TODO timezone aware implicit cast requires SPARK-44180
+    // case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
     case _ => throw new UnsupportedOperationException(s"Expect 1 DATE argument. $description")
   }
 

spark-3.4/clickhouse-spark/src/main/scala/xenon/clickhouse/func/Months.scala

@@ -34,7 +34,8 @@ object Months extends UnboundFunction with ScalarFunction[Int] with ClickhouseEq
 
   override def bind(inputType: StructType): BoundFunction = inputType.fields match {
     case Array(StructField(_, DateType, _, _)) => this
-//    case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
+    // TODO timezone aware implicit cast requires SPARK-44180
+    // case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
     case _ => throw new UnsupportedOperationException(s"Expect 1 DATE argument. $description")
   }
 

spark-3.4/clickhouse-spark/src/main/scala/xenon/clickhouse/func/Years.scala

@@ -34,7 +34,8 @@ object Years extends UnboundFunction with ScalarFunction[Int] with ClickhouseEqu
 
   override def bind(inputType: StructType): BoundFunction = inputType.fields match {
     case Array(StructField(_, DateType, _, _)) => this
-//    case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
+    // TODO timezone aware implicit cast requires SPARK-44180
+    // case Array(StructField(_, TimestampType, _, _)) | Array(StructField(_, TimestampNTZType, _, _)) => this
     case _ => throw new UnsupportedOperationException(s"Expect 1 DATE argument. $description")
   }