From 371d3611cce594a5d108de5fec981c36fad88589 Mon Sep 17 00:00:00 2001 From: Saqib Date: Thu, 3 Sep 2026 00:51:33 +0530 Subject: [PATCH] ci: pass KEYCLOAK_CLIENT_SECRET to the smoke workflow run-smoke.yml now preflights its Keycloak configuration instead of letting the authenticated API tests skip silently and the run go green on nothing. It needs the client secret to do that. `dataspace` is a confidential client, so the ROPC token request returns 401 unauthorized_client without it. The reusable workflow declares the secret optional so this repo kept parsing before this change, but api-smoke fails its preflight until the secret is passed and set. --- .github/workflows/deploy-Dataspace.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/deploy-Dataspace.yml b/.github/workflows/deploy-Dataspace.yml index 31f46e48..6d769c6a 100644 --- a/.github/workflows/deploy-Dataspace.yml +++ b/.github/workflows/deploy-Dataspace.yml @@ -201,6 +201,10 @@ jobs: TEST_PASSWORD_1: ${{ secrets.TEST_PASSWORD_1 }} TEST_EMAIL_2: ${{ secrets.TEST_EMAIL_2 }} TEST_PASSWORD_2: ${{ secrets.TEST_PASSWORD_2 }} + # api-smoke authenticates against Keycloak via ROPC. `dataspace` is a + # confidential client, so without this the token request returns 401 + # and the job fails its preflight. + KEYCLOAK_CLIENT_SECRET: ${{ secrets.KEYCLOAK_CLIENT_SECRET }} # dev only: smoke tests are the real quality gate here. Only once they pass # does this release become the thing a future rollback would target.