Skip to content

Normalize Type-6 passwords in configdelta #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukemanhakkim merged 5 commits into from
Dec 8, 2025
Merged

Normalize Type-6 passwords in configdelta #180

lukemanhakkim merged 5 commits into from
Dec 8, 2025

Conversation

@sanjaydilli
Copy link
Contributor

@sanjaydilli sanjaydilli commented Nov 28, 2025 •
edited
Loading

Fix: Mask encrypted values only in NETCONF get-config while preserving unmasked config for diffs

  • Add deepcopy of config.ele to store unmasked ele_original
  • Apply masking only to NETCONF get/get-config output
  • Ensure ConfigDelta uses ele_original instead of masked tree
  • Prevent masked values (ENCRYPTED) from leaking into edit-config RPCs

@sanjaydilli sanjaydilli marked this pull request as ready for review December 5, 2025 11:36
@sanjaydilli sanjaydilli requested a review from a team as a code owner December 5, 2025 11:36
lukemanhakkim
lukemanhakkim requested changes Dec 8, 2025
View reviewed changes
@lukemanhakkim lukemanhakkim merged commit dd8b90b into main Dec 8, 2025
@lukemanhakkim lukemanhakkim deleted the mask_encrypted_xml branch December 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukemanhakkim lukemanhakkim lukemanhakkim approved these changes

@omehrabi omehrabi omehrabi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanjaydilli @lukemanhakkim @omehrabi