Skip to content

Commit b61d621

Browse files
committed
Merge branch 'release/23.1.0'
2 parents b9b3a66 + b5a9734 commit b61d621

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

CHANGELOG

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
ChangeLog
33
*********
44

5+
23.1.0 (2023-04-17)
6+
===================
7+
- Fix: Improve support for special characters in tabular renderer sheet names. (thanks, @aaxelb!)
8+
59
23.0.0 (2023-03-30)
610
===================
711
- Docs: Basic repository maintenance for 2023; update copyright dates and update COS jobs url.

mfr/extensions/tabular/templates/viewer.mako

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@
3333
3434
for (var sheetName in sheets){
3535
var sheet = sheets[sheetName];
36-
sheetName = sheetName.replace( /(:|\.|\[|\]|,|@|&|\ )/g, '_' ); //Handle characters that can't be in DOM ID's
37-
$("#tabular-tabs").append('<li role="presentation" style="display:inline-block; float: none;"><a id="' + sheetName + '" aria-controls="' + sheetName + '" role="tab" data-toggle="tab">'+ sheetName + '</a></li>');
38-
gridArr[sheetName] = [sheet[0], sheet[1]];
36+
// Handle characters that can't be in DOM ID's
37+
var sheetCoded = window.btoa(encodeURIComponent(sheetName)).replace(/=/g, '');
38+
$("#tabular-tabs").append('<li role="presentation" style="display:inline-block; float: none;"><a id="' + sheetCoded + '" aria-controls="' + sheetCoded + '" role="tab" data-toggle="tab">'+ sheetName + '</a></li>');
39+
gridArr[sheetCoded] = [sheet[0], sheet[1]];
3940
40-
$('#'+sheetName).click(function (e) {
41+
$('#'+sheetCoded).click(function (e) {
4142
e.preventDefault();
4243
var columns = gridArr[$(this).attr('id')][0];
4344
var rows = gridArr[$(this).attr('id')][1];

mfr/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '23.0.0'
1+
__version__ = '23.1.0'

0 commit comments

Comments
 (0)