[HOUSEKEEPING] use common function and remove unused imports and vars (#301)

Co-authored-by: Michael Tarng <20913254+mtarng@users.noreply.github.com>

Author: dennisseah

src/commands/deployment/validate.ts

@@ -7,7 +7,6 @@ import {
   IDeploymentTable,
   updateACRToHLDPipeline
 } from "../../lib/azure/deploymenttable";
-import { validateStorageAccount } from "../../lib/azure/storage";
 import { build as buildCmd, exit as exitCmd } from "../../lib/commandBuilder";
 import { logger } from "../../logger";
 import { IConfigYaml } from "../../types";

src/commands/hld/init.test.ts

@@ -7,6 +7,7 @@ import {
   RENDER_HLD_PIPELINE_FILENAME
 } from "../../lib/constants";
 import { checkoutCommitPushCreatePRLink } from "../../lib/gitutils";
+import { createTempDir } from "../../lib/ioUtil";
 import {
   disableVerboseLogging,
   enableVerboseLogging,
@@ -79,8 +80,7 @@ const testRepoInitialization = async (
   componentPath: string
 ) => {
   // Create random directory to initialize
-  const randomTmpDir = path.join(os.tmpdir(), uuid());
-  fs.mkdirSync(randomTmpDir);
+  const randomTmpDir = createTempDir();
 
   logger.info(`creating randomTmpDir ${randomTmpDir}`);
 

src/commands/project/pipeline.test.ts

@@ -1,10 +1,6 @@
 import { create as createBedrockYaml } from "../../lib/bedrockYaml";
 import { createTempDir } from "../../lib/ioUtil";
-import {
-  disableVerboseLogging,
-  enableVerboseLogging,
-  logger
-} from "../../logger";
+import { disableVerboseLogging, enableVerboseLogging } from "../../logger";
 jest.mock("../../lib/pipelines/pipelines");
 
 import {

src/config.test.ts

@@ -15,8 +15,6 @@ import { createTempDir } from "./lib/ioUtil";
 import { disableVerboseLogging, enableVerboseLogging } from "./logger";
 import { IBedrockFile } from "./types";
 
-const variableGroupName = uuid();
-
 beforeAll(() => {
   enableVerboseLogging();
 });

src/lib/gitutils.with-exec.test.ts

@@ -1,9 +1,6 @@
-import fs from "fs";
-import os from "os";
-import path from "path";
-import uuid from "uuid/v4";
 import { disableVerboseLogging, enableVerboseLogging } from "../logger";
 import { getCurrentBranch } from "./gitutils";
+import { createTempDir } from "./ioUtil";
 import { exec } from "./shell";
 
 beforeAll(() => {
@@ -16,8 +13,7 @@ afterAll(() => {
 
 describe("getCurrentBranch", () => {
   it("should return 'master' when working on a newly created repo with 0 commits", async () => {
-    const randomTmpDir = path.join(os.tmpdir(), uuid());
-    fs.mkdirSync(randomTmpDir);
+    const randomTmpDir = createTempDir();
 
     // initialize the new git repo
     await exec("git", ["init"], { cwd: randomTmpDir });
@@ -27,8 +23,7 @@ describe("getCurrentBranch", () => {
   });
 
   it("should return 'foobar' when working on a newly created repo with 0 commits and 'foobar' has been checked out", async () => {
-    const randomTmpDir = path.join(os.tmpdir(), uuid());
-    fs.mkdirSync(randomTmpDir);
+    const randomTmpDir = createTempDir();
 
     // initialize the new git repo and checkout 'foobar'
     await exec("git", ["init"], { cwd: randomTmpDir });