Skip to content

[Bug]: Investigate scientific implementation warnings and CLI inconsistencies #34

Description

@harryswift01

Bug Report

Clean builds of SIST produce warnings that may indicate uninitialised state or ambiguous control flow. There are also inconsistencies in the command-line documentation and defaults.

These should be investigated before the 1.0.0 release.


To Reproduce

YAML configuration

CLI command used

make -C trans_three clean
make -C trans_three

make -C trans_compete clean
make -C trans_compete

perl master.pl -h

Actual output

Warnings include:

MinWindowSize is used uninitialized
MaxWindowSize is used uninitialized
energy may be used uninitialized

There are also -Wmisleading-indentation warnings.

The CLI help also contains inconsistencies around the threshold option and superhelical-density defaults.

Expected output

  • Scientific variables should be initialised correctly.
  • Control flow should be unambiguous.
  • CLI options and defaults should match the implementation and documentation.

Additional Context

The existing regression suite should be used to verify that any fixes do not unintentionally change scientific results.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions