Cleanup: remove interaction test left-overs

Goldens are moved to `test/goldens`.

Fixed: 404156431
Change-Id: I351e738740d548b5c4f55f75a0f561e382b5c947
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6680473
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

Author: OrKoN

.gitignore

@@ -21,7 +21,6 @@
 /scripts/visualize_deps/out
 config.gypi
 /karma-coverage
-/interactions-coverage
 /perf-data
 npm-debug.log
 /scripts/protocol_typescript/*.js

.stylelintignore

@@ -1,6 +1,5 @@
 front_end/third_party
 karma-coverage
-interactions-coverage
 node_modules
 out
 test/**/fixtures

PRESUBMIT.py

@@ -436,15 +436,6 @@ def CheckForTooLargeFiles(input_api, output_api):
 
 
 def CheckObsoleteScreenshotGoldens(input_api, output_api):
-    interaction_test_root_path = input_api.os_path.join(
-        input_api.PresubmitLocalPath(), 'test', 'interactions')
-    interaction_test_files = [interaction_test_root_path]
-
-    interaction_test_files_changed = _GetAffectedFiles(input_api,
-                                                       interaction_test_files,
-                                                       [], [])
-    if len(interaction_test_files_changed) == 0:
-        return []
     script_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
                                          'scripts', 'test',
                                          'check_obsolete_goldens.js')

eslint.config.mjs

@@ -698,7 +698,6 @@ export default defineConfig([
       'rulesdir/no-assert-equal-boolean-null-undefined': 'error',
       'rulesdir/no-imperative-dom-api': 'off',
       'rulesdir/no-lit-render-outside-of-view': 'off',
-      'rulesdir/no-screenshot-test-outside-perf-panel': 'error',
       'rulesdir/prefer-assert-instance-of': 'error',
       'rulesdir/prefer-assert-is-ok': 'error',
       'rulesdir/prefer-assert-length-of': 'error',

front_end/panels/ai_assistance/BUILD.gn

@@ -62,7 +62,6 @@ devtools_entrypoint("bundle") {
 
   visibility = [
     ":*",
-    "../../../test/interactions/*",
     "../../entrypoints/*",
     "../../ui/components/docs/ai_assistance/*",
     "../explain",

front_end/panels/explain/BUILD.gn

@@ -47,7 +47,6 @@ devtools_entrypoint("bundle") {
 
   visibility = [
     ":*",
-    "../../../test/interactions/*",
     "../../entrypoints/*",
     "../../legacy_test_runner/*",
     "../../ui/components/docs/console_insight/*",

front_end/panels/recorder/models/BUILD.gn

@@ -50,7 +50,6 @@ devtools_entrypoint("bundle") {
     ":*",
     "../*",
     "../../../../test/e2e/recorder/*",
-    "../../../../test/interactions/panels/recorder/*",
     "../../../ui/components/docs/*",
     "../../../ui/components/docs/recorder_injected/*",
     "../../entrypoints/main/*",

scripts/eslint_rules/lib/no-screenshot-test-outside-perf-panel.ts

@@ -21,15 +21,8 @@ const yargsObject = yargs(hideBin(process.argv))
 
 const shouldRemoveFiles = yargsObject.removeFiles === true;
 const SOURCE_ROOT = path.resolve(__dirname, path.join('..', '..'));
-const interactionTestRoot = path.join(SOURCE_ROOT, 'test', 'interactions');
-
 const unitTestRoot = path.join(SOURCE_ROOT, 'front_end');
-// TODO: update the goldens location once interaction tests are
-// migrated.
-const GOLDENS_LOCATION = path.join(interactionTestRoot, 'goldens');
-
-const interactionTestFiles =
-    glob.sync('**/*_test.ts', {cwd: interactionTestRoot}).map(file => path.join(interactionTestRoot, file));
+const GOLDENS_LOCATION = path.join(SOURCE_ROOT, 'test', 'goldens');
 const unitTestFiles = glob.sync('**/*.test.ts', {cwd: unitTestRoot}).map(file => path.join(unitTestRoot, file));
 
 function findScreenshotsToCheck(folder) {
@@ -65,10 +58,9 @@ function checkGoldensForPlatform(platform) {
 
   for (const golden of goldens) {
     const relativeGoldenPath = path.relative(platformRoot, golden).replace(/\\/g, '/');
-    const interactions = checkFolder(relativeGoldenPath, interactionTestFiles);
     const units = checkFolder(relativeGoldenPath, unitTestFiles);
 
-    if (!interactions && !units) {
+    if (!units) {
       obsoleteImages.push(path.join(platform, relativeGoldenPath));
     }
   }