Skip to content

Commit c5d5aa9

Browse files
blbradleyjdee
authored andcommitted
[Android] remove WeakReference from BranchUniversalReferralInitListener
The weakref is getting garbage collected when the app is not opened via a Branch.io link.
1 parent 587ce0f commit c5d5aa9

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

android/src/main/java/io/branch/rnbranch/RNBranchModule.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public class RNBranchModule extends ReactContextBaseJavaModule {
7676

7777
private static JSONObject initSessionResult = null;
7878
private BroadcastReceiver mInitSessionEventReceiver = null;
79-
private static WeakReference<Branch.BranchUniversalReferralInitListener> initListener = null;
79+
private static Branch.BranchUniversalReferralInitListener initListener = null;
8080

8181
private static Activity mActivity = null;
8282
private static boolean mUseDebug = false;
@@ -86,7 +86,7 @@ public class RNBranchModule extends ReactContextBaseJavaModule {
8686
private AgingHash<String, BranchUniversalObject> mUniversalObjectMap = new AgingHash<>(AGING_HASH_TTL);
8787

8888
public static void initSession(final Uri uri, Activity reactActivity, Branch.BranchUniversalReferralInitListener anInitListener) {
89-
initListener = new WeakReference<>(anInitListener);
89+
initListener = anInitListener;
9090
initSession(uri, reactActivity);
9191
}
9292

@@ -148,8 +148,7 @@ public void onInitFinished(JSONObject referringParams, BranchError error) {
148148
LinkProperties linkProperties = LinkProperties.getReferredLinkProperties();
149149

150150
if (initListener != null) {
151-
Branch.BranchUniversalReferralInitListener listener = initListener.get();
152-
if (listener != null) listener.onInitFinished(branchUniversalObject, linkProperties, error);
151+
initListener.onInitFinished(branchUniversalObject, linkProperties, error);
153152
}
154153
generateLocalBroadcast(referringParams, referringUri, branchUniversalObject, linkProperties, error);
155154
}

0 commit comments

Comments
 (0)