Skip to content

Commit 9773769

Browse files
authored
Merge pull request #305 from BranchMetrics/native-field-mappings
Fix bad field mappings
2 parents 6eb6721 + 57b0abb commit 9773769

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

android/src/main/java/io/branch/rnbranch/RNBranchModule.java

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -654,8 +654,8 @@ public ContentMetadata createContentMetadata(ReadableMap map) {
654654
}
655655

656656
if (map.hasKey("productCategory")) {
657-
ProductCategory category = ProductCategory.valueOf(map.getString("productCategory"));
658-
metadata.setProductCategory(category);
657+
ProductCategory category = getProductCategory(map.getString("productCategory"));
658+
if (category != null) metadata.setProductCategory(category);
659659
}
660660

661661
if (map.hasKey("productVariant")) {
@@ -809,6 +809,18 @@ else if (mode.equals("public"))
809809
return branchUniversalObject;
810810
}
811811

812+
@Nullable
813+
public ProductCategory getProductCategory(final String stringValue) {
814+
ProductCategory[] possibleValues = ProductCategory.class.getEnumConstants();
815+
for (ProductCategory value: possibleValues) {
816+
if (stringValue.equals(value.getName())) {
817+
return value;
818+
}
819+
}
820+
Log.w(REACT_CLASS, "Could not find product category " + stringValue);
821+
return null;
822+
}
823+
812824
@ReactMethod
813825
public void redeemRewards(int value, String bucket, Promise promise)
814826
{

ios/BranchContentMetadata+RNBranch.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ @implementation BranchContentMetadata(RNBranch)
3535
@"addressCity": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressCity:) type:NSString.class],
3636
@"addressRegion": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressRegion:) type:NSString.class],
3737
@"addressCountry": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressCountry:) type:NSString.class],
38-
@"addressPostalCode": [RNBranchProperty propertyWithSetterSelector:@selector(setPostalCode:) type:NSString.class],
38+
@"addressPostalCode": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressPostalCode:) type:NSString.class],
3939
@"latitude": [RNBranchProperty propertyWithSetterSelector:@selector(setLatitudeWithNumber:) type:NSNumber.class],
4040
@"longitude": [RNBranchProperty propertyWithSetterSelector:@selector(setLongitudeWithNumber:) type:NSNumber.class],
4141
@"imageCaptions": [RNBranchProperty propertyWithSetterSelector:@selector(setImageCaptionsWithArray:) type:NSArray.class],

ios/RNBranch.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ - (BranchUniversalObject *)findUniversalObjectWithIdent:(NSString *)ident reject
374374
resolve(NSNull.null);
375375
}
376376

377-
#pragma mark logEventWithUniversalObjects
377+
#pragma mark logEvent
378378
RCT_EXPORT_METHOD(
379379
logEvent:(NSArray *)identifiers
380380
eventName:(NSString *)eventName

0 commit comments

Comments
 (0)