Skip to content

Commit 8e015c0

Browse files
committed
build.gradle update to correct RN requirement. Also changed an error message and comment in the native layers.
1 parent 9c40994 commit 8e015c0

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ repositories {
77

88
android {
99
compileSdkVersion 23
10-
buildToolsVersion "23.0.1"
10+
buildToolsVersion '25.0.0'
1111

1212
defaultConfig {
1313
minSdkVersion 16
@@ -18,6 +18,6 @@ android {
1818
}
1919

2020
dependencies {
21-
compile 'com.facebook.react:react-native:0.20.+'
21+
compile 'com.facebook.react:react-native:+' // From node_modules
2222
compile 'io.branch.sdk.android:library:2.+'
2323
}

android/src/main/java/io/branch/rnbranch/RNBranchModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,8 @@ public static LinkProperties createLinkProperties(ReadableMap linkPropertiesMap,
335335
private BranchUniversalObject findUniversalObjectOrReject(final String ident, final Promise promise) {
336336
BranchUniversalObject universalObject = mUniversalObjectMap.get(ident);
337337

338-
// This is extremely unlikely and basically a logic error.
339338
if (universalObject == null) {
340-
final String errorMessage = "BranchUniversalObject not found for ident " + ident + ". Do not reuse a BUO after calling release() in JS. Create a new instance instead.";
339+
final String errorMessage = "BranchUniversalObject not found for ident " + ident + ".";
341340
promise.reject(UNIVERSAL_OBJECT_NOT_FOUND_ERROR_CODE, errorMessage);
342341
}
343342

ios/RNBranch.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,8 @@ - (BranchUniversalObject *)findUniversalObjectWithIdent:(NSString *)ident reject
124124
{
125125
BranchUniversalObject *universalObject = self.universalObjectMap[ident];
126126

127-
// This is extremely unlikely and amounts to a logic error.
128127
if (!universalObject) {
129-
NSString *errorMessage = [NSString stringWithFormat:@"BranchUniversalObject for ident %@ not found. Do not reuse a BUO after calling release() in JS. Create a new instance instead.", ident];
128+
NSString *errorMessage = [NSString stringWithFormat:@"BranchUniversalObject for ident %@ not found.", ident];
130129

131130
NSError *error = [NSError errorWithDomain:RNBranchErrorDomain
132131
code:RNBranchUniversalObjectNotFoundError

0 commit comments

Comments
 (0)