simplicityhl-0.5.0 does not compile

[ivanlele]

Project version

0.5.0

Project

compiler

What happened?

Recently, we released a new version of rust-simplicity with breaking changes (0.7.1). If someone runs cargo add simplicityhl or cargo add simplicityhl@0.5.0, Cargo will currently resolve the simplicity-lang dependency to 0.7.1 because we did not pin the dependency strictly enough.

Let's create a branch from the simplicityhl-0.5.0 tag, apply a hotfix by changing the dependency to:

simplicity-lang = { version = "=0.7.0" }

and quickly release a simplicityhl-0.5.1 patch version.

Minimal reproduction steps

cargo new test-shl && cd test-shl
cargo add simplicityhl
cargo build

[ivanlele]

@apoelstra @KyrylR is there a better way to fix this?

[stringhandler]

Just a note that this is only a problem for the crate reference. Users of the simc binary or compiling a simc binary should be unaffected.

I second the suggestion for a 0.5.1 patch

[apoelstra]

First, let's yank rust-simplicity 0.7.1 if it has breaking changes.

[stringhandler]

First, let's yank rust-simplicity 0.7.1 if it has breaking changes.

Agree

[apoelstra]

Let's create a branch from the simplicityhl-0.5.0 tag, apply a hotfix by changing the dependency to:

Definitely not! Using = constraints in Cargo.toml will greatly increase the number of problems we have to deal with.

[stringhandler]

Yeah, the problem here was the incorrect versioning of rust-simplicity

[apoelstra]

Yanked.

And I see what happened -- in BlockstreamResearch/rust-simplicity#364 we did a minor version bump because there were no breaking changes. Then we realized that we couldn't publish this without also bumping rust-simplicity-sys, which we did. But that bump, by changing the set of jets, turned #364 into a breaking change.

[apoelstra]

We will need to re-release rust-simplicity as 0.8.0.

[ivanlele]

We will need to re-release rust-simplicity as 0.8.0.

BlockstreamResearch/rust-simplicity#366

[apoelstra]

We can close this issue since the compilation breakage is addressed by yanking.