Skip to content

Replace 'pycon-us-2026-recap' post image#921

Merged
kjaymiller merged 1 commit into
BlackPythonDevs:gh-pagesfrom
DennyPerez18:new-recap-image
Jun 8, 2026
Merged

Replace 'pycon-us-2026-recap' post image#921
kjaymiller merged 1 commit into
BlackPythonDevs:gh-pagesfrom
DennyPerez18:new-recap-image

Conversation

@DennyPerez18

Copy link
Copy Markdown
Contributor

Issue Link 🔗:

Issue: #[Issue_Number]

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

  • What: Provide an overview of the issue this PR addresses. Explain the context and background information.

  • Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.

  • How: Explain how these changes will affect the project or end-users.

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

Add any additional notes or comments that might be helpful for the reviewers.

@kjaymiller

Copy link
Copy Markdown
Contributor

This is approved... I'm confused because it will not let me approve it?

@kjaymiller kjaymiller requested a review from Copilot June 8, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kjaymiller kjaymiller self-assigned this Jun 8, 2026
@kjaymiller kjaymiller self-requested a review June 8, 2026 12:38
@kjaymiller kjaymiller self-requested a review June 8, 2026 12:39

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denny there are two blog posts that use this image... we need to swap the first one with the swag image if you're going to replace this image for the recap.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you are proposing. I decided to change the image, since there were two posts with the same one (diff of before and after attached); do you have other recommendations or should this be left as is?

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no this is perfect... I couldn't find the image for the "Black Python Devs at PyCon US 2026" post.

All Good

@kjaymiller kjaymiller self-requested a review June 8, 2026 14:02
@kjaymiller kjaymiller merged commit 29c333d into BlackPythonDevs:gh-pages Jun 8, 2026
2 checks passed
@DennyPerez18 DennyPerez18 deleted the new-recap-image branch June 8, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants