From de4d83dc4914001b9d30c3292dd3c9d62b3ca2db Mon Sep 17 00:00:00 2001 From: Alejandro Barazarte Date: Tue, 2 Jun 2026 11:43:47 +0200 Subject: [PATCH 1/3] feat(NOJIRA): Upgrade customer-profile-api to version 2.6.0 and bump project version to 10.4.0 --- CHANGELOG.md | 4 ++++ pom.xml | 2 +- .../com/backbase/stream/mapper/PartyMapper.java | 13 +++++++++++++ stream-dbs-clients/pom.xml | 2 +- 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ab358622..05ea9260b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,10 @@ # Changelog All notable changes to this project will be documented in this file. +## [10.4.0] +### Changed +- Upgrade `customer-profile-api` version from `1.17.1` to `2.6.0`. + ## [10.3.0] ### Changed - Upgrade `investment-service-api` version from `1.4.1` to `1.6.0`; regenerate API clients and fix all compilation errors in production and test sources. diff --git a/pom.xml b/pom.xml index 316465a98..8dd840f69 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.backbase.stream stream-services - 10.3.0 + 10.4.0 pom Stream :: Services diff --git a/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java b/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java index ed43eaea8..1ae36b628 100644 --- a/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java +++ b/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java @@ -1,10 +1,13 @@ package com.backbase.stream.mapper; import com.backbase.customerprofile.api.integration.v1.model.PartyUpsertDto; +import com.backbase.customerprofile.api.integration.v1.model.PostalAddressDto; import com.backbase.stream.legalentity.model.Party; +import com.backbase.stream.legalentity.model.PartyPostalAddress; import org.mapstruct.Mapper; import org.mapstruct.Mapping; import org.mapstruct.MappingConstants; +import org.mapstruct.ValueMapping; @Mapper(componentModel = MappingConstants.ComponentModel.SPRING) public interface PartyMapper { @@ -12,4 +15,14 @@ public interface PartyMapper { @Mapping(target = "additions", source = "customFields") PartyUpsertDto partyToPartyUpsertDto(Party party); + @ValueMapping(source = "BUSINESS", target = "BUSINESS") + @ValueMapping(source = "CORRESPONDENCE", target = "CORRESPONDENCE") + @ValueMapping(source = "DELIVERY_TO", target = "DELIVERYTO") + @ValueMapping(source = "MAIL_TO", target = "MAILTO") + @ValueMapping(source = "PO_BOX", target = "PO_BOX") + @ValueMapping(source = "POSTAL", target = "POSTAL") + @ValueMapping(source = "RESIDENTIAL", target = "RESIDENTIAL") + @ValueMapping(source = "STATEMENT", target = "STATEMENT") + PostalAddressDto mapPostalAddressType(PartyPostalAddress partyPostalAddress); + } \ No newline at end of file diff --git a/stream-dbs-clients/pom.xml b/stream-dbs-clients/pom.xml index 813d90e98..ed5c9ef6b 100644 --- a/stream-dbs-clients/pom.xml +++ b/stream-dbs-clients/pom.xml @@ -220,7 +220,7 @@ com.backbase.flow.customer-profile.api customer-profile - 1.17.1 + 2.6.0 api zip ${project.build.directory}/yaml From 7a17913fb856bd1cb205400e887c0c9b9fd49b02 Mon Sep 17 00:00:00 2001 From: Alejandro Barazarte Date: Tue, 2 Jun 2026 12:11:17 +0200 Subject: [PATCH 2/3] feat(NOJIRA): downgrade project version to 10.3.0 in pom.xml --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8dd840f69..316465a98 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.backbase.stream stream-services - 10.4.0 + 10.3.0 pom Stream :: Services From 6d3669ede4611e31e6b35f776baf1abddfda869d Mon Sep 17 00:00:00 2001 From: Alejandro Barazarte Date: Wed, 3 Jun 2026 15:52:27 +0200 Subject: [PATCH 3/3] feat(NOJIRA): add tests for postal address type mapping --- .../backbase/stream/mapper/PartyMapper.java | 2 +- .../backbase/stream/mapper/MapperTest.java | 28 +++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java b/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java index 1ae36b628..0c1ce6412 100644 --- a/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java +++ b/stream-customer-profile/customer-profile-core/src/main/java/com/backbase/stream/mapper/PartyMapper.java @@ -23,6 +23,6 @@ public interface PartyMapper { @ValueMapping(source = "POSTAL", target = "POSTAL") @ValueMapping(source = "RESIDENTIAL", target = "RESIDENTIAL") @ValueMapping(source = "STATEMENT", target = "STATEMENT") - PostalAddressDto mapPostalAddressType(PartyPostalAddress partyPostalAddress); + PostalAddressDto.TypeEnum mapPostalAddressType(PartyPostalAddress.TypeEnum partyPostalAddress); } \ No newline at end of file diff --git a/stream-customer-profile/customer-profile-core/src/test/java/com/backbase/stream/mapper/MapperTest.java b/stream-customer-profile/customer-profile-core/src/test/java/com/backbase/stream/mapper/MapperTest.java index bd0845d80..df22aeadb 100644 --- a/stream-customer-profile/customer-profile-core/src/test/java/com/backbase/stream/mapper/MapperTest.java +++ b/stream-customer-profile/customer-profile-core/src/test/java/com/backbase/stream/mapper/MapperTest.java @@ -7,12 +7,18 @@ import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertTrue; +import com.backbase.customerprofile.api.integration.v1.model.PostalAddressDto; import com.backbase.stream.legalentity.model.Party; +import com.backbase.stream.legalentity.model.PartyPostalAddress; import com.navercorp.fixturemonkey.FixtureMonkey; import java.util.ArrayList; import java.util.HashMap; +import java.util.stream.Stream; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.context.SpringBootTest; @@ -118,6 +124,7 @@ void shouldMapPopulatedCollections() { var party = fixtureMonkey.giveMeBuilder(Party.class) .size("phoneNumbers", 2) .size("postalAddresses", 1) + .set("postalAddresses[0].type", PartyPostalAddress.TypeEnum.BUSINESS) .size("customFields", 3) .size("partyPartyRelationships", 1) .sample(); @@ -129,6 +136,7 @@ void shouldMapPopulatedCollections() { assertNotNull(resultDto.getPostalAddresses()); assertEquals(1, resultDto.getPostalAddresses().size()); + assertEquals(PostalAddressDto.TypeEnum.BUSINESS, resultDto.getPostalAddresses().getFirst().getType()); assertNotNull(resultDto.getAdditions()); assertEquals(3, resultDto.getAdditions().size()); @@ -199,4 +207,24 @@ void shouldMapNullCollections() { assertTrue(resultDto.getElectronicAddresses().getUrls().isEmpty()); } + @ParameterizedTest + @DisplayName("Should map address type correctly") + @MethodSource("addressTypes") + void shouldMapAddressType(PostalAddressDto.TypeEnum expectedType, PartyPostalAddress.TypeEnum actualType) { + var mapped = partyMapper.mapPostalAddressType(actualType); + assertEquals(expectedType, mapped); + } + + private static Stream addressTypes() { + return Stream.of( + Arguments.of(PostalAddressDto.TypeEnum.BUSINESS, PartyPostalAddress.TypeEnum.BUSINESS), + Arguments.of(PostalAddressDto.TypeEnum.CORRESPONDENCE, PartyPostalAddress.TypeEnum.CORRESPONDENCE), + Arguments.of(PostalAddressDto.TypeEnum.DELIVERYTO, PartyPostalAddress.TypeEnum.DELIVERY_TO), + Arguments.of(PostalAddressDto.TypeEnum.MAILTO, PartyPostalAddress.TypeEnum.MAIL_TO), + Arguments.of(PostalAddressDto.TypeEnum.PO_BOX, PartyPostalAddress.TypeEnum.PO_BOX), + Arguments.of(PostalAddressDto.TypeEnum.POSTAL, PartyPostalAddress.TypeEnum.POSTAL), + Arguments.of(PostalAddressDto.TypeEnum.RESIDENTIAL, PartyPostalAddress.TypeEnum.RESIDENTIAL), + Arguments.of(PostalAddressDto.TypeEnum.STATEMENT, PartyPostalAddress.TypeEnum.STATEMENT) + ); + } }