Se añadieron servicios al API Client para gestión de BHEs, receptores y servicios provistos. Se reestructuró la carpeta tests/. Se añadieron más testss de acuerdo a los servicios nuevos, y se modificaron tests ya existentes. Se adaptó la documentación a la modificación de API Client y tests. Se estandarizó el código y los tests. Se modificó test.env-dist, y se alteraron algunas variables de entorno necesarias. Se modificó la versión de PHP necesaria para funcionar: Ahora es PHP 8.3.

Author: SantiagoFiol

.github/workflows/ci.yml

@@ -27,21 +27,25 @@ jobs:
       - name: Install Composer dependencies
         run: composer install --no-progress --no-suggest
 
-      - name: Create temporary env file
-        run: |
-          echo "BHEXPRESS_API_TOKEN=${{ secrets.BHEXPRESS_API_TOKEN }}" >> tests/test.env
-          echo "BHEXPRESS_EMISOR_RUT=${{ secrets.BHEXPRESS_EMISOR_RUT }}" >> tests/test.env
-
       - name: Run PHP tests read only
+        env:
+          BHEXPRESS_API_TOKEN: ${{ secrets.BHEXPRESS_API_TOKEN }}
+          BHEXPRESS_EMISOR_RUT: ${{ vars.BHEXPRESS_EMISOR_RUT }}
         run: |
-          composer tests_readonly
+          composer tests-readonly
 
-      - name: Upload PHPUnit result report
+      - name: Upload pytest result report
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: tests-testdox-php_${{ matrix.php-version }}.txt
-          path: var/tests-testdox.txt
+          name: tests-results-python_${{ matrix.python-version }}.xml
+          path: var/tests-results.xml
+
+      - name: Upload Coverage Report
+        uses: actions/upload-artifact@v4
+        with:
+          name: tests-coverage-python_${{ matrix.python-version }}.xml
+          path: var/tests-coverage.xml
 
       - name: Display PHP version
         run: php -v

.gitignore

@@ -6,5 +6,7 @@ Dockerfile
 var/
 tools/
 build/
+tests/archivos/bhe_emitidas_pdf/*
 
-prueba-ejemplo.php
+prueba-ejemplo.php
+phpstan-baseline.neon

.scrutinizer.yml

@@ -0,0 +1,37 @@
+checks:
+  php: true
+
+build:
+  nodes:
+    analysis:
+      tests:
+        override:
+          - php-scrutinizer-run
+          - command: composer tests-readonly
+            coverage:
+              file: var/tests-coverage.xml
+              format: clover
+      environment:
+        php:
+          version: 8.3.13
+          pecl_extensions:
+            - xdebug
+  dependencies:
+    before:
+      - composer install --no-progress --prefer-dist
+
+tools:
+  php_code_sniffer:
+    enabled: true
+    config:
+      standard: PSR12
+
+filter:
+  paths:
+    - src/*
+  excluded_paths:
+    - resources/*
+    - tests/*
+    - tools/*
+    - var/*
+    - vendor/*

composer.json

@@ -16,22 +16,32 @@
         "source": "https://github.com/BHExpress/bhexpress-api-client-php"
     },
     "require": {
-        "php": "^8.2",
-        "guzzlehttp/guzzle": "^7"
+        "guzzlehttp/guzzle": "^7",
+        "php": "^8.2 || ^8.3"
     },
     "require-dev": {
-        "ext-xdebug": "*",
         "friendsofphp/php-cs-fixer": "^3.63",
         "phpstan/phpstan": "^1.12",
-        "phpunit/phpunit": "^11.4"
+        "phpunit/phpunit": "^11.3",
+        "vlucas/phpdotenv": "^5.6"
     },
     "autoload": {
-        "psr-4": {"bhexpress\\api_client\\": "src/"}
+        "psr-4": {
+            "bhexpress\\api_client\\": "src/",
+            "bhexpress\\api_client\\bhe\\": "src/bhe/",
+            "bhexpress\\tests\\bhe\\": "tests/bhe/boletas/"
+        }
     },
     "scripts": {
         "docs": "php tools/phpdocumentor run --config=phpdoc.xml",
         "tests": "XDEBUG_MODE=coverage vendor/bin/phpunit --configuration=phpunit.xml",
-        "tests_readonly": "vendor/bin/phpunit --configuration=phpunit.xml --no-coverage --testsuite readonly",
-        "tests_authneeded": "vendor/bin/phpunit --configuration=phpunit.xml --no-coverage --testsuite authneeded"
+        "tests-boletas": "vendor/bin/phpunit --configuration=phpunit.xml --no-coverage --testsuite boletas",
+        "tests-servicios": "vendor/bin/phpunit --configuration=phpunit.xml --no-coverage --testsuite servicios",
+        "tests-receptores": "vendor/bin/phpunit --configuration=phpunit.xml --no-coverage --testsuite receptores",
+        "tests-readonly": "XDEBUG_MODE=coverage vendor/bin/phpunit --configuration=phpunit.xml --filter 'testCalcularMontoBruto|testCalcularMontoLiquido|testListarBhes|testListarReceptores|testListarServicios'",
+        "phpcs-fix": "php-cs-fixer fix -v --config=php-cs-fixer.php .",
+        "phpcs-fix-dry-run": "php-cs-fixer fix -v --dry-run --diff --config=php-cs-fixer.php .",
+        "phpstan": "phpstan analyse --configuration=phpstan.neon --memory-limit=1G",
+        "phpstan-export": "phpstan analyse --configuration=phpstan.neon --level 9 --generate-baseline"
     }
 }