[Warlock] Fix Shared Fate tick behaviors (simulationcraft#10055)

Author: Azevara

engine/class_modules/warlock/sc_warlock.cpp

@@ -121,9 +121,15 @@ warlock_td_t::warlock_td_t( player_t* target, warlock_t& p )
   debuffs_shared_fate = make_buff( *this, "shared_fate", p.hero.shared_fate_debuff )
                             ->set_tick_zero( false )
                             ->set_tick_time_behavior( buff_tick_time_behavior::HASTED )
+                            ->set_tick_behavior( buff_tick_behavior::REFRESH )
+                            ->set_refresh_behavior( buff_refresh_behavior::PANDEMIC )
+                            ->set_partial_tick( true )
                             ->set_period( p.hero.shared_fate_debuff->effectN( 1 ).period() )
-                            ->set_tick_callback( [ this, target ]( buff_t*, int, timespan_t )
-                              { warlock.proc_actions.shared_fate->execute_on_target( target ); } );
+                            ->set_tick_callback( [ this, target ]( buff_t* b, int, timespan_t actual_tick_time )
+                              {
+                                helpers::set_shared_fate_tick_factor( &warlock, actual_tick_time.total_seconds() / b->tick_time().total_seconds() );
+                                warlock.proc_actions.shared_fate->execute_on_target( target );
+                              } );
 
   target->register_on_demise_callback( &p, [ this ]( player_t* ) { target_demise(); } );
 }

engine/class_modules/warlock/sc_warlock.hpp

@@ -980,5 +980,7 @@ namespace helpers
   void trigger_blackened_soul( warlock_t* p, bool malevolence );
 
   void trigger_jackpot_ua( warlock_t* p );
+
+  void set_shared_fate_tick_factor( warlock_t* p, double f );
 }
 }  // namespace warlock

engine/class_modules/warlock/sc_warlock_actions.cpp

@@ -1559,12 +1559,24 @@ using namespace helpers;
 
   struct shared_fate_t : public warlock_spell_t
   {
+    double tick_factor;
+
     shared_fate_t( warlock_t* p )
       : warlock_spell_t( "Shared Fate", p, p->hero.shared_fate_dmg )
     {
       background = dual = true;
       aoe = -1;
       reduced_aoe_targets = p->hero.shared_fate->effectN( 1 ).base_value();
+      tick_factor = 1.0;
+    }
+
+    double composite_da_multiplier( const action_state_t* s ) const override
+    {
+      double m = warlock_spell_t::composite_da_multiplier( s );
+
+      m *= tick_factor;
+
+      return m;
     }
   };
 
@@ -4824,6 +4836,9 @@ using namespace helpers;
     }
   }
 
+  void helpers::set_shared_fate_tick_factor( warlock_t* p, double f )
+  { debug_cast<shared_fate_t*>( p->proc_actions.shared_fate )->tick_factor = f; }
+
   // Event for spawning Wild Imps for Demonology
   imp_delay_event_t::imp_delay_event_t( warlock_t* p, double delay, double exp ) : player_event_t( *p, timespan_t::from_millis( delay ) )
   { diff = timespan_t::from_millis( exp - delay ); }