Code Coverage

refs #23

Author: Art4

src/DocumentLink.php

@@ -173,7 +173,7 @@ private function setLink($name, $link)
 	{
 		if ( ! is_string($link) and ! is_object($link) )
 		{
-			throw new ValidationException('Link has to be an object or string, "' . gettype($link) . '" given.');
+			throw new ValidationException('Link attribute has to be an object or string, "' . gettype($link) . '" given.');
 		}
 
 		if ( is_string($link) )

src/ErrorLink.php

@@ -110,7 +110,7 @@ private function setLink($name, $link)
 	{
 		if ( ! is_string($link) and ! is_object($link) )
 		{
-			throw new ValidationException('Link has to be an object or string, "' . gettype($link) . '" given.');
+			throw new ValidationException('Link attribute has to be an object or string, "' . gettype($link) . '" given.');
 		}
 
 		if ( is_string($link) )

src/RelationshipLink.php

@@ -176,7 +176,7 @@ private function setLink($name, $link)
 	{
 		if ( ! is_string($link) and ! is_object($link) )
 		{
-			throw new ValidationException('Link has to be an object or string, "' . gettype($link) . '" given.');
+			throw new ValidationException('Link attribute has to be an object or string, "' . gettype($link) . '" given.');
 		}
 
 		if ( is_string($link) )

src/Resource/ItemLink.php

@@ -54,14 +54,7 @@ public function __construct($object, FactoryManagerInterface $manager, AccessInt
 
 		$this->container = new DataContainer();
 
-		$object_vars = get_object_vars($object);
-
-		if ( count($object_vars) === 0 )
-		{
-			return $this;
-		}
-
-		foreach ($object_vars as $name => $value)
+		foreach (get_object_vars($object) as $name => $value)
 		{
 			$this->set($name, $value);
 		}
@@ -102,7 +95,7 @@ protected function set($name, $link)
 		// - an object ("link object") which can contain the following members:
 		if ( ! is_object($link) and ! is_string($link) )
 		{
-			throw new ValidationException('Link has to be an object or string, "' . gettype($link) . '" given.');
+			throw new ValidationException('Link attribute has to be an object or string, "' . gettype($link) . '" given.');
 		}
 
 		if ( is_string($link) )

tests/unit/DocumentLinkTest.php

@@ -114,6 +114,31 @@ public function testCreateWithoutObjectThrowsException($input)
 		$link = new DocumentLink($input, $this->manager, $this->parent);
 	}
 
+	/**
+	 * @dataProvider jsonValuesProvider
+	 *
+	 * test create without object or string attribute throws exception
+	 */
+	public function testCreateWithoutObjectOrStringAttributeThrowsException($input)
+	{
+		// Input must be an object
+		if ( gettype($input) === 'string' or gettype($input) === 'object' )
+		{
+			return;
+		}
+
+		$object = new \stdClass();
+		$object->self = 'http://example.org/self';
+		$object->input = $input;
+
+		$this->setExpectedException(
+			'Art4\JsonApiClient\Exception\ValidationException',
+			'Link attribute has to be an object or string, "' . gettype($input) . '" given.'
+		);
+
+		$link = new DocumentLink($object, $this->manager, $this->parent);
+	}
+
 	/**
 	 * @dataProvider jsonValuesProvider
 	 *

tests/unit/ErrorLinkTest.php

@@ -116,6 +116,31 @@ public function testCreateWithDataprovider($input)
 		$link = new ErrorLink($input, $this->manager);
 	}
 
+	/**
+	 * @dataProvider jsonValuesProvider
+	 *
+	 * test create without object or string attribute throws exception
+	 */
+	public function testCreateWithoutObjectOrStringAttributeThrowsException($input)
+	{
+		// Input must be an object
+		if ( gettype($input) === 'string' or gettype($input) === 'object' )
+		{
+			return;
+		}
+
+		$object = new \stdClass();
+		$object->about = 'http://example.org/about';
+		$object->input = $input;
+
+		$this->setExpectedException(
+			'Art4\JsonApiClient\Exception\ValidationException',
+			'Link attribute has to be an object or string, "' . gettype($input) . '" given.'
+		);
+
+		$link = new ErrorLink($object, $this->manager);
+	}
+
 	/**
 	 * @dataProvider jsonValuesProvider
 	 *

tests/unit/RelationshipLinkTest.php

@@ -185,7 +185,7 @@ public function testPaginationNotParsedIfRelationshipIdentifierCollectionNotExis
 			->method('has')
 			->with($this->equalTo('data'))
 			->will($this->returnValue(true));
-		
+
 		// Mock identifier item
 		$data = $this->getMockBuilder('Art4\JsonApiClient\Resource\IdentifierInterface')
 			->getMock();
@@ -233,6 +233,31 @@ public function testCreateWithoutObjectThrowsException($input)
 		$link = new RelationshipLink($input, $this->manager, $this->relationship);
 	}
 
+	/**
+	 * @dataProvider jsonValuesProvider
+	 *
+	 * test create without object or string attribute throws exception
+	 */
+	public function testCreateWithoutObjectOrStringAttributeThrowsException($input)
+	{
+		// Input must be an object
+		if ( gettype($input) === 'string' or gettype($input) === 'object' )
+		{
+			return;
+		}
+
+		$object = new \stdClass();
+		$object->self = 'http://example.org/self';
+		$object->input = $input;
+
+		$this->setExpectedException(
+			'Art4\JsonApiClient\Exception\ValidationException',
+			'Link attribute has to be an object or string, "' . gettype($input) . '" given.'
+		);
+
+		$link = new RelationshipLink($object, $this->manager, $this->relationship);
+	}
+
 	/**
 	 * @test object contains at least one of the following: self, related
 	 */

tests/unit/Resource/ItemLinkTest.php

@@ -72,6 +72,30 @@ public function testCreateWithoutObjectThrowsException($input)
 		$link = new ItemLink($input, $this->manager, $this->parent);
 	}
 
+	/**
+	 * @dataProvider jsonValuesProvider
+	 *
+	 * test create without object or string attribute throws exception
+	 */
+	public function testCreateWithoutObjectOrStringAttributeThrowsException($input)
+	{
+		// Input must be an object
+		if ( gettype($input) === 'string' or gettype($input) === 'object' )
+		{
+			return;
+		}
+
+		$object = new \stdClass();
+		$object->input = $input;
+
+		$this->setExpectedException(
+			'Art4\JsonApiClient\Exception\ValidationException',
+			'Link attribute has to be an object or string, "' . gettype($input) . '" given.'
+		);
+
+		$link = new ItemLink($object, $this->manager, $this->parent);
+	}
+
 	/**
 	 * @test
 	 */