chore: enable all modern analyzers

egil · egil · commit 32218fd7278b · 2024-10-13T17:48:33.000Z
diff --git a/src/AngleSharp.Diffing.Tests/Core/AttributeComparisonTest.cs b/src/AngleSharp.Diffing.Tests/Core/AttributeComparisonTest.cs
@@ -65,7 +65,7 @@ public void Test005()
         var test = ToAttributeComparisonSource(@"<br foo=""bar"">", "foo");
         var comparison = new AttributeComparison(control, test);
 
-        var (actualCtrlElm, actualTestElm) = comparison.GetAttributeElements();
+        var (actualCtrlElm, actualTestElm) = comparison.AttributeElements;
 
         actualCtrlElm.ShouldBe(control.ElementSource.Node);
         actualTestElm.ShouldBe(test.ElementSource.Node);
@@ -135,7 +135,7 @@ public void Test005()
         var test = ToAttributeComparisonSource(@"<br foo=""bar"">", "foo");
         var comparison = new AttributeComparison(control, test);
 
-        var (actualCtrlElm, actualTestElm) = comparison.GetAttributeElements();
+        var (actualCtrlElm, actualTestElm) = comparison.AttributeElements;
 
         actualCtrlElm.ShouldBe(control.ElementSource.Node);
         actualTestElm.ShouldBe(test.ElementSource.Node);
diff --git a/src/AngleSharp.Diffing.Tests/Core/DiffingEngineTestBase.cs b/src/AngleSharp.Diffing.Tests/Core/DiffingEngineTestBase.cs
@@ -2,7 +2,7 @@ namespace AngleSharp.Diffing.Core;
 
 public abstract class DiffingEngineTestBase : DiffingTestBase
 {
-    public DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)
+    protected DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)
     {
     }
 
@@ -24,7 +24,7 @@ protected static HtmlDiffer CreateHtmlDiffer(
         );
     }
 
-    private class MockDiffingStrategy : IDiffingStrategy
+    private sealed class MockDiffingStrategy : IDiffingStrategy
     {
         private readonly Func<ComparisonSource, FilterDecision>? _nodeFilter;
         private readonly Func<AttributeComparisonSource, FilterDecision>? _attrFilter;
diff --git a/src/AngleSharp.Diffing.Tests/Core/HtmlDifferenceEngineTest.cs b/src/AngleSharp.Diffing.Tests/Core/HtmlDifferenceEngineTest.cs
@@ -510,14 +510,14 @@ private static Func<AttributeComparisonSource, FilterDecision> SpecificAttrFilte
     #endregion
 
     #region CustomDiff
-    public record CustomNodeDiff : NodeDiff
+    public sealed record CustomNodeDiff : NodeDiff
     {
         public CustomNodeDiff(in Comparison comparison) : base(comparison)
         {
         }
     }
 
-    public record CustomAttrDiff : AttrDiff
+    public sealed record CustomAttrDiff : AttrDiff
     {
         public CustomAttrDiff(in AttributeComparison comparison) : base(comparison, AttrDiffKind.Unspecified)
         {
diff --git a/src/AngleSharp.Diffing.Tests/DiffingTestBase.cs b/src/AngleSharp.Diffing.Tests/DiffingTestBase.cs
@@ -4,11 +4,18 @@ public abstract class DiffingTestBase : IClassFixture<DiffingTestFixture>
 {
     private readonly DiffingTestFixture _testFixture;
 
+
+    public static readonly TheoryData<CompareResult> SameAndSkipCompareResult = new TheoryData<CompareResult>
+    {
+        CompareResult.Same,
+        CompareResult.Skip,
+    };
+
     protected IDiffContext DummyContext { get; } = new DiffContext(default(IElement), default(IElement));
 
     protected INodeList EmptyNodeList => ToNodeList("");
 
-    public DiffingTestBase(DiffingTestFixture fixture)
+    protected DiffingTestBase(DiffingTestFixture fixture)
     {
         _testFixture = fixture;
     }
@@ -68,10 +75,4 @@ protected SourceMap ToSourceMap(string html, ComparisonSourceType sourceType = C
         var source = ToComparisonSource(html, sourceType);
         return new SourceMap(source);
     }
-
-    public static TheoryData<CompareResult> SameAndSkipCompareResult = new TheoryData<CompareResult>
-    {
-        CompareResult.Same,
-        CompareResult.Skip,
-    };
 }
diff --git a/src/AngleSharp.Diffing.Tests/GlobalSuppressions.cs b/src/AngleSharp.Diffing.Tests/GlobalSuppressions.cs
@@ -0,0 +1,9 @@
+﻿// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "CA2201:Do not raise reserved exception types", Justification = "Not relevant in tests.")]
+[assembly: SuppressMessage("Design", "CA1034:Nested types should not be visible", Justification = "Not relevant in tests")]
diff --git a/src/AngleSharp.Diffing.Tests/Strategies/DiffingStrategyPipelineTest.cs b/src/AngleSharp.Diffing.Tests/Strategies/DiffingStrategyPipelineTest.cs
@@ -6,7 +6,7 @@ public DiffingStrategyPipelineTest(DiffingTestFixture fixture) : base(fixture)
     {
     }
 
-    private FilterDecision NegateDecision(FilterDecision decision) => decision switch
+    private static FilterDecision NegateDecision(FilterDecision decision) => decision switch
     {
         FilterDecision.Keep => FilterDecision.Exclude,
         FilterDecision.Exclude => FilterDecision.Keep,
diff --git a/src/AngleSharp.Diffing.Tests/Strategies/TextNodeStrategies/TextNodeTestBase.cs b/src/AngleSharp.Diffing.Tests/Strategies/TextNodeStrategies/TextNodeTestBase.cs
@@ -18,7 +18,7 @@ public abstract class TextNodeTestBase : DiffingTestBase
 
     public static readonly IEnumerable<object[]> WhitespaceCharStrings = AllWhitespaceCharacters.Select(c => new string[] { c.ToString(CultureInfo.InvariantCulture) }).ToArray();
 
-    public TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)
+    protected TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)
     {
     }
 }
diff --git a/src/AngleSharp.Diffing/Core/AttributeComparison.cs b/src/AngleSharp.Diffing/Core/AttributeComparison.cs
@@ -10,6 +10,6 @@ public readonly record struct AttributeComparison(in AttributeComparisonSource C
     /// <summary>
     /// Returns the control and test elements which the control and test attributes belongs to.
     /// </summary>
-    public (IElement ControlElement, IElement TestElement) GetAttributeElements()
+    public readonly (IElement ControlElement, IElement TestElement) AttributeElements
         => ((IElement)Control.ElementSource.Node, (IElement)Test.ElementSource.Node);
 }
diff --git a/src/AngleSharp.Diffing/Core/AttributeComparisonSource.cs b/src/AngleSharp.Diffing/Core/AttributeComparisonSource.cs
@@ -30,6 +30,7 @@ namespace AngleSharp.Diffing.Core;
     /// </summary>
     /// <param name="attributeName">Name of the attribute.</param>
     /// <param name="elementSource">The source of the element the attribute belongs to.</param>
+    [SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Attribute names should be safe to lowercase.")]
     public AttributeComparisonSource(string attributeName, in ComparisonSource elementSource)
     {
         if (string.IsNullOrEmpty(attributeName))
diff --git a/src/AngleSharp.Diffing/Core/CompareDecision.cs b/src/AngleSharp.Diffing/Core/CompareDecision.cs
@@ -9,7 +9,7 @@ public enum CompareDecision
     /// <summary>
     /// Use when the compare result is unknown.
     /// </summary>
-    Unknown = 0,
+    None = 0,
     /// <summary>
     /// Use when the two compared nodes or attributes are the same.
     /// </summary>
diff --git a/src/AngleSharp.Diffing/Core/CompareResult.cs b/src/AngleSharp.Diffing/Core/CompareResult.cs
@@ -10,7 +10,7 @@ public readonly record struct CompareResult(CompareDecision Decision, IDiff? Dif
     /// <summary>
     /// Use when the compare result is unknown.
     /// </summary>
-    public static readonly CompareResult Unknown = default;
+    public static readonly CompareResult Unknown;
 
     /// <summary>
     /// Use when the two compared nodes or attributes are the same.
diff --git a/src/AngleSharp.Diffing/Core/ComparisonSource.cs b/src/AngleSharp.Diffing/Core/ComparisonSource.cs
@@ -64,6 +64,7 @@ public ComparisonSource(INode node, int index, string parentsPath, ComparisonSou
     /// </summary>
     /// <param name="node"></param>
     /// <returns></returns>
+    [SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Nodenames are safe to lower case.")]
     public static string GetNodePathSegment(INode node)
     {
         var index = GetPathIndex(node);
diff --git a/src/AngleSharp.Diffing/Core/HtmlDifferenceEngine.cs b/src/AngleSharp.Diffing/Core/HtmlDifferenceEngine.cs
@@ -90,13 +90,13 @@ private IEnumerable<IDiff> CompareNode(in Comparison comparison)
         if (compareRes.Decision.HasFlag(CompareDecision.Different))
         {
             IDiff diff = compareRes.Diff ?? new NodeDiff(comparison);
-            return new[] { diff };
+            return [diff];
         }
 
         return Array.Empty<IDiff>();
     }
 
-    private IEnumerable<IDiff> CompareElement(in Comparison comparison)
+    private List<IDiff> CompareElement(in Comparison comparison)
     {
         var result = new List<IDiff>();
 
diff --git a/src/AngleSharp.Diffing/Extensions/EmptyHtmlCollection.cs b/src/AngleSharp.Diffing/Extensions/EmptyHtmlCollection.cs
@@ -8,10 +8,12 @@ public class EmptyHtmlCollection<T> : IHtmlCollection<T> where T : IElement
 {
     /// <inheritdoc/>
     [SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations")]
+    [SuppressMessage("Usage", "CA2201:Do not raise reserved exception types")]
     public T this[int index] => throw new IndexOutOfRangeException();
 
     /// <inheritdoc/>
     [SuppressMessage("Design", "CA1065:Do not raise exceptions in unexpected locations")]
+    [SuppressMessage("Usage", "CA2201:Do not raise reserved exception types")]
     public T this[string id] => throw new IndexOutOfRangeException();
 
     /// <inheritdoc/>
diff --git a/src/AngleSharp.Diffing/Extensions/UnexpectedDOMTreeStructureException.cs b/src/AngleSharp.Diffing/Extensions/UnexpectedDOMTreeStructureException.cs
@@ -13,6 +13,17 @@ public sealed class UnexpectedDOMTreeStructureException : Exception
     public UnexpectedDOMTreeStructureException()
         : base("The DOM tree structure was not as expected by AngleSharp.Diffing.") { }
 
-    private UnexpectedDOMTreeStructureException(SerializationInfo info, StreamingContext context)
-        : base(info, context) { }
+    /// <summary>
+    /// Creates an instance of the <see cref="UnexpectedDOMTreeStructureException"/>.
+    /// </summary>
+    public UnexpectedDOMTreeStructureException(string message) : base(message)
+    {
+    }
+
+    /// <summary>
+    /// Creates an instance of the <see cref="UnexpectedDOMTreeStructureException"/>.
+    /// </summary>
+    public UnexpectedDOMTreeStructureException(string message, Exception innerException) : base(message, innerException)
+    {
+    }
 }
diff --git a/src/AngleSharp.Diffing/Strategies/AttributeStrategies/ClassAttributeComparer.cs b/src/AngleSharp.Diffing/Strategies/AttributeStrategies/ClassAttributeComparer.cs
@@ -18,7 +18,7 @@ public static CompareResult Compare(in AttributeComparison comparison, CompareRe
         if (!IsBothClassAttributes(comparison))
             return CompareResult.FromDiff(new AttrDiff(comparison, AttrDiffKind.Name));
 
-        var (ctrlElm, testElm) = comparison.GetAttributeElements();
+        var (ctrlElm, testElm) = comparison.AttributeElements;
         if (ctrlElm.ClassList.Length != testElm.ClassList.Length)
             return CompareResult.FromDiff(new AttrDiff(comparison, AttrDiffKind.Value));
 
diff --git a/src/AngleSharp.Diffing/Strategies/AttributeStrategies/OrderingStyleAttributeComparer.cs b/src/AngleSharp.Diffing/Strategies/AttributeStrategies/OrderingStyleAttributeComparer.cs
@@ -26,7 +26,7 @@ private static bool IsStyleAttributeComparison(in AttributeComparison comparison
 
     private static CompareResult CompareElementStyle(in AttributeComparison comparison)
     {
-        var (ctrlElm, testElm) = comparison.GetAttributeElements();
+        var (ctrlElm, testElm) = comparison.AttributeElements;
         var ctrlStyle = ctrlElm.GetStyle();
         var testStyle = testElm.GetStyle();
         return CompareCssStyleDeclarations(ctrlStyle, testStyle)
diff --git a/src/AngleSharp.Diffing/Strategies/AttributeStrategies/StyleAttributeComparer.cs b/src/AngleSharp.Diffing/Strategies/AttributeStrategies/StyleAttributeComparer.cs
@@ -26,7 +26,7 @@ private static bool IsStyleAttributeComparison(in AttributeComparison comparison
 
     private static CompareResult CompareElementStyle(in AttributeComparison comparison)
     {
-        var (ctrlElm, testElm) = comparison.GetAttributeElements();
+        var (ctrlElm, testElm) = comparison.AttributeElements;
         var ctrlStyle = ctrlElm.GetStyle();
         var testStyle = testElm.GetStyle();
         return CompareCssStyleDeclarations(ctrlStyle, testStyle)
diff --git a/src/AngleSharp.Diffing/Strategies/DiffingStrategyPipeline.cs b/src/AngleSharp.Diffing/Strategies/DiffingStrategyPipeline.cs
@@ -123,7 +123,7 @@ public IDiffingStrategyCollection AddComparer(CompareStrategy<AttributeCompariso
         return this;
     }
 
-    private FilterDecision Filter<T>(in T source, List<FilterStrategy<T>> filterStrategies)
+    private static FilterDecision Filter<T>(in T source, List<FilterStrategy<T>> filterStrategies)
     {
         var result = FilterDecision.Keep;
         for (int i = 0; i < filterStrategies.Count; i++)
@@ -133,7 +133,7 @@ private FilterDecision Filter<T>(in T source, List<FilterStrategy<T>> filterStra
         return result;
     }
 
-    private CompareResult Compare<TComparison>(in TComparison comparison, List<CompareStrategy<TComparison>> compareStrategies, CompareResult initialResult)
+    private static CompareResult Compare<TComparison>(in TComparison comparison, List<CompareStrategy<TComparison>> compareStrategies, CompareResult initialResult)
     {
         var result = initialResult;
         foreach (var comparer in compareStrategies)
diff --git a/src/AngleSharp.Diffing/Strategies/ElementStrategies/DiffMatchSelectorReturnedTooManyResultsException.cs b/src/AngleSharp.Diffing/Strategies/ElementStrategies/DiffMatchSelectorReturnedTooManyResultsException.cs
@@ -27,11 +27,4 @@ public DiffMatchSelectorReturnedTooManyResultsException(string message) : base(m
     public DiffMatchSelectorReturnedTooManyResultsException(string message, Exception innerException) : base(message, innerException)
     {
     }
-
-    /// <summary>
-    /// Creates a <see cref="DiffMatchSelectorReturnedTooManyResultsException"/>.
-    /// </summary>
-    protected DiffMatchSelectorReturnedTooManyResultsException(SerializationInfo info, StreamingContext context) : base(info, context)
-    {
-    }
 }
diff --git a/src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreAttributesElementComparer.cs b/src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreAttributesElementComparer.cs
@@ -20,7 +20,7 @@ public static CompareResult Compare(in Comparison comparison, CompareResult curr
 
         return currentDecision.Decision switch
         {
-            CompareDecision.Unknown => CompareResult.SkipAttributes,
+            CompareDecision.None => CompareResult.SkipAttributes,
             CompareDecision.Same => CompareResult.SkipAttributes,
             CompareDecision.Different => CompareResult.SkipAttributes,
             CompareDecision.SkipChildren => CompareResult.SkipChildrenAndAttributes,
diff --git a/src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreChildrenElementComparer.cs b/src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreChildrenElementComparer.cs
@@ -20,7 +20,7 @@ public static CompareResult Compare(in Comparison comparison, CompareResult curr
 
         return currentDecision.Decision switch
         {
-            CompareDecision.Unknown => CompareResult.SkipChildren,
+            CompareDecision.None => CompareResult.SkipChildren,
             CompareDecision.Same => CompareResult.SkipChildren,
             CompareDecision.Different => CompareResult.SkipChildren,
             CompareDecision.SkipAttributes => CompareResult.SkipChildrenAndAttributes,
diff --git a/src/AngleSharp.Diffing/Strategies/IDiffingStrategyCollection.cs b/src/AngleSharp.Diffing/Strategies/IDiffingStrategyCollection.cs
@@ -3,6 +3,7 @@ namespace AngleSharp.Diffing.Strategies;
 /// <summary>
 /// Represents a collection of diffing strategies.
 /// </summary>
+[SuppressMessage("Naming", "CA1711:Identifiers should not have incorrect suffix", Justification = "Ignored.")]
 public interface IDiffingStrategyCollection
 {
     /// <summary>
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -1,19 +1,26 @@
 <Project>
-  <PropertyGroup>
-    <Version>0.18.2</Version>
-  </PropertyGroup>
+	<PropertyGroup>
+		<Version>0.18.3</Version>
+	</PropertyGroup>
 
-  <PropertyGroup>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <LangVersion>11.0</LangVersion>
-    <Nullable>enable</Nullable>
-    <WarningsAsErrors>CS8600;CS8602;CS8603;CS8625</WarningsAsErrors>
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>../Key.snk</AssemblyOriginatorKeyFile>
-  </PropertyGroup>
+	<PropertyGroup>
+		<ImplicitUsings>enable</ImplicitUsings>
+		<LangVersion>latest</LangVersion>
+		<Nullable>enable</Nullable>
+		<WarningsAsErrors>CS8600;CS8602;CS8603;CS8625</WarningsAsErrors>
+		<SignAssembly>true</SignAssembly>
+		<AssemblyOriginatorKeyFile>../Key.snk</AssemblyOriginatorKeyFile>
+	</PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="AngleSharp" Version="0.17.0" />
-    <PackageReference Include="AngleSharp.Css" Version="0.17.0" />
-  </ItemGroup>
+	<PropertyGroup Label="Analyzer settings">
+		<AnalysisMode>AllEnabledByDefault</AnalysisMode>
+		<EnableNETAnalyzers>true</EnableNETAnalyzers>
+		<AnalysisLevel>latest</AnalysisLevel>
+		<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+	</PropertyGroup>
+
+	<ItemGroup>
+		<PackageReference Include="AngleSharp" Version="0.17.0" />
+		<PackageReference Include="AngleSharp.Css" Version="0.17.0" />
+	</ItemGroup>
 </Project>

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ namespace AngleSharp.Diffing.Core;`
`2`	`2`
`3`	`3`	`public abstract class DiffingEngineTestBase : DiffingTestBase`
`4`	`4`	`{`
`5`		`- public DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)`
	`5`	`+ protected DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)`
`6`	`6`	`{`
`7`	`7`	`}`
`8`	`8`
`@@ -24,7 +24,7 @@ protected static HtmlDiffer CreateHtmlDiffer(`
`24`	`24`	`);`
`25`	`25`	`}`
`26`	`26`
`27`		`- private class MockDiffingStrategy : IDiffingStrategy`
	`27`	`+ private sealed class MockDiffingStrategy : IDiffingStrategy`
`28`	`28`	`{`
`29`	`29`	`private readonly Func<ComparisonSource, FilterDecision>? _nodeFilter;`
`30`	`30`	`private readonly Func<AttributeComparisonSource, FilterDecision>? _attrFilter;`
Original file line number	Diff line number	Diff line change
`@@ -510,14 +510,14 @@ private static Func<AttributeComparisonSource, FilterDecision> SpecificAttrFilte`
`510`	`510`	`#endregion`
`511`	`511`
`512`	`512`	`#region CustomDiff`
`513`		`- public record CustomNodeDiff : NodeDiff`
	`513`	`+ public sealed record CustomNodeDiff : NodeDiff`
`514`	`514`	`{`
`515`	`515`	`public CustomNodeDiff(in Comparison comparison) : base(comparison)`
`516`	`516`	`{`
`517`	`517`	`}`
`518`	`518`	`}`
`519`	`519`
`520`		`- public record CustomAttrDiff : AttrDiff`
	`520`	`+ public sealed record CustomAttrDiff : AttrDiff`
`521`	`521`	`{`
`522`	`522`	`public CustomAttrDiff(in AttributeComparison comparison) : base(comparison, AttrDiffKind.Unspecified)`
`523`	`523`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,11 +4,18 @@ public abstract class DiffingTestBase : IClassFixture<DiffingTestFixture>`
`4`	`4`	`{`
`5`	`5`	`private readonly DiffingTestFixture _testFixture;`
`6`	`6`
	`7`	`+`
	`8`	`+ public static readonly TheoryData<CompareResult> SameAndSkipCompareResult = new TheoryData<CompareResult>`
	`9`	`+ {`
	`10`	`+ CompareResult.Same,`
	`11`	`+ CompareResult.Skip,`
	`12`	`+ };`
	`13`	`+`
`7`	`14`	`protected IDiffContext DummyContext { get; } = new DiffContext(default(IElement), default(IElement));`
`8`	`15`
`9`	`16`	`protected INodeList EmptyNodeList => ToNodeList("");`
`10`	`17`
`11`		`- public DiffingTestBase(DiffingTestFixture fixture)`
	`18`	`+ protected DiffingTestBase(DiffingTestFixture fixture)`
`12`	`19`	`{`
`13`	`20`	`_testFixture = fixture;`
`14`	`21`	`}`
`@@ -68,10 +75,4 @@ protected SourceMap ToSourceMap(string html, ComparisonSourceType sourceType = C`
`68`	`75`	`var source = ToComparisonSource(html, sourceType);`
`69`	`76`	`return new SourceMap(source);`
`70`	`77`	`}`
`71`		`-`
`72`		`- public static TheoryData<CompareResult> SameAndSkipCompareResult = new TheoryData<CompareResult>`
`73`		`- {`
`74`		`- CompareResult.Same,`
`75`		`- CompareResult.Skip,`
`76`		`- };`
`77`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ public DiffingStrategyPipelineTest(DiffingTestFixture fixture) : base(fixture)`
`6`	`6`	`{`
`7`	`7`	`}`
`8`	`8`
`9`		`- private FilterDecision NegateDecision(FilterDecision decision) => decision switch`
	`9`	`+ private static FilterDecision NegateDecision(FilterDecision decision) => decision switch`
`10`	`10`	`{`
`11`	`11`	`FilterDecision.Keep => FilterDecision.Exclude,`
`12`	`12`	`FilterDecision.Exclude => FilterDecision.Keep,`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public abstract class TextNodeTestBase : DiffingTestBase`
`18`	`18`
`19`	`19`	`public static readonly IEnumerable<object[]> WhitespaceCharStrings = AllWhitespaceCharacters.Select(c => new string[] { c.ToString(CultureInfo.InvariantCulture) }).ToArray();`
`20`	`20`
`21`		`- public TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)`
	`21`	`+ protected TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)`
`22`	`22`	`{`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,6 @@ public readonly record struct AttributeComparison(in AttributeComparisonSource C`
`10`	`10`	`/// <summary>`
`11`	`11`	`/// Returns the control and test elements which the control and test attributes belongs to.`
`12`	`12`	`/// </summary>`
`13`		`- public (IElement ControlElement, IElement TestElement) GetAttributeElements()`
	`13`	`+ public readonly (IElement ControlElement, IElement TestElement) AttributeElements`
`14`	`14`	`=> ((IElement)Control.ElementSource.Node, (IElement)Test.ElementSource.Node);`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ namespace AngleSharp.Diffing.Core;`
`30`	`30`	`/// </summary>`
`31`	`31`	`/// <param name="attributeName">Name of the attribute.</param>`
`32`	`32`	`/// <param name="elementSource">The source of the element the attribute belongs to.</param>`
	`33`	`+ [SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Attribute names should be safe to lowercase.")]`
`33`	`34`	`public AttributeComparisonSource(string attributeName, in ComparisonSource elementSource)`
`34`	`35`	`{`
`35`	`36`	`if (string.IsNullOrEmpty(attributeName))`