Merge pull request #1 from Amadeco/Amadeco-patch-1

feat(seo): improve code quality in ApplySeoMetadata observer

Author: Amadeco

Observer/ApplySeoMetadata.php

@@ -69,30 +69,30 @@ public function execute(Observer $observer): void
         /** @var CustomEntity|null $entity */
         $entity = $this->registry->registry('current_custom_entity');
 
-        if (!$entity || !$entity instanceof CustomEntity) {
+        if (!$entity || !($entity instanceof CustomEntity)) {
             return;
         }
 
-        // Apply meta title
-        $metaTitle = $entity->getData('meta_title');
+        // Apply meta title only if explicitly set
+        $metaTitle = $entity->getMetaTitle();
         if (!empty($metaTitle)) {
             $this->pageConfig->getTitle()->set($metaTitle);
         }
 
-        // Apply meta description
-        $metaDescription = $entity->getData('meta_description');
+        // Apply meta description only if explicitly set
+        $metaDescription = $entity->getMetaDescription();
         if (!empty($metaDescription)) {
             $this->pageConfig->setDescription($metaDescription);
         }
 
-        // Apply meta keywords
-        $metaKeywords = $entity->getData('meta_keywords');
+        // Apply meta keywords only if explicitly set
+        $metaKeywords = $entity->getMetaKeywords();
         if (!empty($metaKeywords)) {
             $this->pageConfig->setKeywords($metaKeywords);
         }
 
         // Apply meta robots only if explicitly set
-        $metaRobots = $entity->getData('meta_robots');
+        $metaRobots = $entity->getMetaRobots();
         if (!empty($metaRobots)) {
             $this->pageConfig->setRobots($metaRobots);
         }

Plugin/CustomEntityPlugin.php

@@ -1,5 +1,11 @@
 <?php
-
+/**
+ * Amadeco SmileCustomEntitySeo module
+ *
+ * @category  Amadeco
+ * @package   Amadeco_SmileCustomEntitySeo
+ * @copyright Ilan Parmentier
+ */
 declare(strict_types=1);
 
 namespace Amadeco\SmileCustomEntitySeo\Plugin;
@@ -28,4 +34,4 @@ public function afterGetInterfaceAttributes(CustomEntity $subject, array $result
             CustomEntitySeoInterface::META_ROBOTS
         ]);
     }
-}
+}