allow builds without jwt

Author: zvonand

ci/jobs/fast_test.py

@@ -55,7 +55,6 @@ def clone_submodules():
         "contrib/incbin",
         "contrib/yaml-cpp",
         "contrib/corrosion",
-        "contrib/jwt-cpp",
     ]
 
     res = Shell.check("git submodule sync", verbose=True, strict=True)

src/Access/AuthenticationData.cpp

@@ -14,8 +14,6 @@
 #include <boost/algorithm/hex.hpp>
 #include <Poco/SHA1Engine.h>
 
-#include <picojson/picojson.h>
-
 #include "config.h"
 
 #if USE_SSL
@@ -29,6 +27,10 @@
 #     include <bcrypt.h>
 #endif
 
+#if USE_JWT_CPP
+#include <picojson/picojson.h>
+#endif
+
 namespace DB
 {
 
@@ -658,6 +660,7 @@ AuthenticationData AuthenticationData::fromAST(const ASTAuthenticationData & que
         auth_data.setHTTPAuthenticationServerName(server);
         auth_data.setHTTPAuthenticationScheme(scheme);
     }
+#if USE_JWT_CPP
     else if (query.type == AuthenticationType::JWT)
     {
         if (!args.empty())
@@ -672,6 +675,7 @@ AuthenticationData AuthenticationData::fromAST(const ASTAuthenticationData & que
             auth_data.setJWTClaims(value);
         }
     }
+#endif
     else
     {
         throw Exception(ErrorCodes::LOGICAL_ERROR, "Unexpected ASTAuthenticationData structure");

src/Access/TokenProcessors.h

@@ -1,15 +1,22 @@
 #pragma once
 
 #include <Access/Credentials.h>
-#include <Access/Common/JWKSProvider.h>
 #include <Poco/Util/AbstractConfiguration.h>
 
+#if USE_JWT_CPP
+#include <Access/Common/JWKSProvider.h>
 #include <jwt-cpp/jwt.h>
 #include <jwt-cpp/traits/kazuho-picojson/traits.h>
+#endif
 
 namespace DB
 {
 
+namespace ErrorCodes
+{
+extern const int NOT_IMPLEMENTED;
+}
+
 class ITokenProcessor
 {
 public:
@@ -20,7 +27,10 @@ class ITokenProcessor
     : processor_name(processor_name_), token_cache_lifetime(token_cache_lifetime_), username_claim(username_claim_), groups_claim(groups_claim_) {}
     virtual ~ITokenProcessor() = default;
 
-    virtual bool resolveAndValidate(TokenCredentials & credentials) const = 0;
+    virtual bool resolveAndValidate(TokenCredentials &) const
+    {
+        throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Not implemented for ITokenProcessor interface");
+    }
 
     virtual bool checkClaims(const TokenCredentials &, const String &) { return true; }
 
@@ -37,10 +47,9 @@ class ITokenProcessor
     const UInt64 token_cache_lifetime;
     const String username_claim;
     const String groups_claim;
-
-    std::set<String> parseGroupsFromJsonArray(picojson::array groups_array) const;
 };
 
+#if USE_JWT_CPP
 class StaticKeyJwtProcessor : public ITokenProcessor
 {
 public:
@@ -163,4 +172,6 @@ class OpenIdTokenProcessor : public ITokenProcessor
     std::optional<JwksJwtProcessor> jwt_validator = std::nullopt;
 };
 
+#endif
+
 }

src/Access/TokenProcessorsJWT.cpp

@@ -157,18 +157,21 @@ bool check_claims(const String & claims, const picojson::value::object & payload
 
 }
 
-std::set<String> ITokenProcessor::parseGroupsFromJsonArray(picojson::array groups_array) const
+namespace
+{
+std::set<String> parseGroupsFromJsonArray(picojson::array groups_array)
 {
     std::set<String> external_groups_names;
 
-    for (const auto & group: groups_array)
+    for (const auto & group : groups_array)
     {
         if (group.is<std::string>())
             external_groups_names.insert(group.get<std::string>());
     }
 
     return external_groups_names;
 }
+}
 
 StaticKeyJwtProcessor::StaticKeyJwtProcessor(const String & processor_name_,
                                              UInt64 token_cache_lifetime_,