Skip to content

Commit 54969bf

Browse files
committed
address comments
1 parent de52d33 commit 54969bf

2 files changed

Lines changed: 6 additions & 23 deletions

File tree

PWGDQ/Core/MixingHandler.h

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,22 +42,11 @@ class MixingHandler : public TNamed
4242
float eta;
4343
float phi;
4444
uint32_t filteringFlags;
45-
// globalIndex is unique only within a dataframe, so the dataframe sequence is part of the track identity
46-
uint64_t dataFrameSequence = 0;
47-
uint64_t trackGlobalIndex = 0;
48-
// electric charge of the track; 0 means "not set" and disables the charge dependent pair variables
49-
int8_t sign = 0;
50-
bool IsSamePhysicalTrack(const MixingTrack& other) const
51-
{
52-
return dataFrameSequence == other.dataFrameSequence && trackGlobalIndex == other.trackGlobalIndex;
53-
}
5445
// Clear a bit once the track was used in mixing for that bit for the required pool depth.
5546
void ClearBit(uint32_t mask) { filteringFlags &= ~mask; }
5647
void Print() const
5748
{
58-
std::cout << "pt: " << pt << ", eta: " << eta << ", phi: " << phi << ", sign: " << static_cast<int>(sign)
59-
<< ", filteringFlags: " << filteringFlags
60-
<< ", dataframe: " << dataFrameSequence << ", track: " << trackGlobalIndex << std::endl;
49+
std::cout << "pt: " << pt << ", eta: " << eta << ", phi: " << phi << ", filteringFlags: " << filteringFlags << std::endl;
6150
}
6251
};
6352

PWGDQ/Tasks/tableReader_withAssoc.h

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1431,8 +1431,6 @@ struct AnalysisSameEventPairing {
14311431

14321432
HistogramManager* fHistMan = nullptr;
14331433
MixingHandler fMixingHandler;
1434-
// dataframe counter, part of the track identity in the mixing pools
1435-
uint64_t fMixingDataFrameSequence = 0;
14361434

14371435
o2::analysis::DQMlResponse<float> fDQMlResponse;
14381436
std::vector<float> fOutputMlPsi2ee; // TODO: check this is needed or not
@@ -1994,10 +1992,6 @@ struct AnalysisSameEventPairing {
19941992
// constexpr bool fillFlowReso = eventHasQvector || eventHasQvectorCentr;
19951993
bool isSelectedBDT = false;
19961994
fNPairPerEvent = 0;
1997-
uint64_t currentMixingDataFrameSequence = 0;
1998-
if (fConfigRunMixingAcrossTFs) {
1999-
currentMixingDataFrameSequence = ++fMixingDataFrameSequence;
2000-
}
20011995

20021996
for (auto const& event : events) {
20031997
if (!event.isEventSelected_bit(0)) {
@@ -2512,7 +2506,7 @@ struct AnalysisSameEventPairing {
25122506
continue;
25132507
}
25142508
auto t1 = assoc.template reducedtrack_as<TTracks>();
2515-
MixingHandler::MixingTrack mixingTrack(t1.pt(), t1.eta(), t1.phi(), trackFilterForMixing, currentMixingDataFrameSequence, static_cast<uint64_t>(assoc.reducedtrackId()), static_cast<int8_t>(t1.sign()));
2509+
MixingHandler::MixingTrack mixingTrack(t1.pt(), t1.eta(), t1.phi(), trackFilterForMixing);
25162510
if (t1.sign() > 0) {
25172511
mixingEvent.AddTrack1(mixingTrack);
25182512
} else {
@@ -2543,9 +2537,9 @@ struct AnalysisSameEventPairing {
25432537
}
25442538
// run ++ pairing
25452539
for (auto const& t2 : poolEvent.tracks1) {
2546-
// check the two-track filter for the mixed pair and skip the same track associated to both collisions
2540+
// check the two-track filter for the mixed pair
25472541
uint32_t mixedTwoTrackFilter = t1.filteringFlags & t2.filteringFlags;
2548-
if (!mixedTwoTrackFilter || t1.IsSamePhysicalTrack(t2)) {
2542+
if (!mixedTwoTrackFilter) {
25492543
continue;
25502544
}
25512545
VarManager::FillPairMEAcrossTFs(t1, t2);
@@ -2573,9 +2567,9 @@ struct AnalysisSameEventPairing {
25732567
}
25742568
// run -- pairing
25752569
for (auto const& t2 : poolEvent.tracks2) {
2576-
// check the two-track filter for the mixed pair and skip the same track associated to both collisions
2570+
// check the two-track filter for the mixed pair
25772571
uint32_t mixedTwoTrackFilter = t1.filteringFlags & t2.filteringFlags;
2578-
if (!mixedTwoTrackFilter || t1.IsSamePhysicalTrack(t2)) {
2572+
if (!mixedTwoTrackFilter) {
25792573
continue;
25802574
}
25812575
VarManager::FillPairMEAcrossTFs(t1, t2);

0 commit comments

Comments
 (0)