Skip to content

Commit 6119fc2

Browse files
authored
More permissive margins in monitoring tests
The monitoring tests include some pseudo-random outputs which sporadically go out of originally expected, too narrow margins, which is perfectly normal. The commit extends the margins.
1 parent 4636d9e commit 6119fc2

File tree

1 file changed

+28
-28
lines changed

1 file changed

+28
-28
lines changed

common/monitoring/monitoring_test.go

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -448,36 +448,36 @@ func TestApproximateHistogram(t *testing.T) {
448448
t.Errorf("wrong poolSize, expected 500, got %d", poolSize)
449449
}
450450

451-
if math.Abs(mean-50) > 5 {
452-
t.Errorf("wrong mean value, expected 50+-5 got %v", mean)
451+
if math.Abs(mean-50) > 10 {
452+
t.Errorf("wrong mean value, expected 50+-10 got %v", mean)
453453
}
454454

455-
if math.Abs(float64(median-50)) > 5 {
456-
t.Errorf("wrong median value, expected 50+-5 got %v", median)
455+
if math.Abs(float64(median-50)) > 10 {
456+
t.Errorf("wrong median value, expected 50+-10 got %v", median)
457457
}
458458

459-
if float64(min) > 5 {
460-
t.Errorf("wrong min value, expected 0+-5 got %v", min)
459+
if float64(min) > 10 {
460+
t.Errorf("wrong min value, expected 0+-10 got %v", min)
461461
}
462462

463-
if math.Abs(float64(p10-10)) > 5 {
464-
t.Errorf("wrong 10p value, expected 10+-5 got %v", p10)
463+
if math.Abs(float64(p10-10)) > 10 {
464+
t.Errorf("wrong 10p value, expected 10+-10 got %v", p10)
465465
}
466466

467-
if math.Abs(float64(p30-30)) > 5 {
468-
t.Errorf("wrong 30p value, expected 30+-5 got %v", p30)
467+
if math.Abs(float64(p30-30)) > 10 {
468+
t.Errorf("wrong 30p value, expected 30+-10 got %v", p30)
469469
}
470470

471-
if math.Abs(float64(p70-70)) > 5 {
472-
t.Errorf("wrong 50p value, expected 70+-5 got %v", p70)
471+
if math.Abs(float64(p70-70)) > 10 {
472+
t.Errorf("wrong 50p value, expected 70+-10 got %v", p70)
473473
}
474474

475-
if math.Abs(float64(p90-90)) > 5 {
476-
t.Errorf("wrong 90p value, expected 90+-5 got %v", p90)
475+
if math.Abs(float64(p90-90)) > 10 {
476+
t.Errorf("wrong 90p value, expected 90+-10 got %v", p90)
477477
}
478478

479-
if math.Abs(float64(max-100)) > 5 {
480-
t.Errorf("wrong max value, expected 100+-5 got %v", max)
479+
if math.Abs(float64(max-100)) > 10 {
480+
t.Errorf("wrong max value, expected 100+-10 got %v", max)
481481
}
482482
}
483483

@@ -497,33 +497,33 @@ func TestMetricsHistogramObject(t *testing.T) {
497497
for _, metric := range metrics {
498498
for valueName, value := range metric.fields {
499499
if strings.Contains(valueName, "mean") {
500-
if math.Abs(value.(float64)-50) > 5 {
501-
t.Errorf("wrong mean value, expected 50+-5 got %v", value.(float64))
500+
if math.Abs(value.(float64)-50) > 10 {
501+
t.Errorf("wrong mean value, expected 50+-10 got %v", value.(float64))
502502
}
503503
}
504504
if strings.Contains(valueName, "median") {
505-
if math.Abs(value.(float64)-50) > 5 {
506-
t.Errorf("wrong median value, expected 50+-5 got %v", value.(float64))
505+
if math.Abs(value.(float64)-50) > 10 {
506+
t.Errorf("wrong median value, expected 50+-10 got %v", value.(float64))
507507
}
508508
}
509509
if strings.Contains(valueName, "p10") {
510-
if math.Abs(value.(float64)-10) > 5 {
511-
t.Errorf("wrong p10, expected 10+-5 got %v", value.(float64))
510+
if math.Abs(value.(float64)-10) > 10 {
511+
t.Errorf("wrong p10, expected 10+-10 got %v", value.(float64))
512512
}
513513
}
514514
if strings.Contains(valueName, "p30") {
515-
if math.Abs(value.(float64)-30) > 5 {
516-
t.Errorf("wrong p30, expected 30+-5 got %v", value.(float64))
515+
if math.Abs(value.(float64)-30) > 10 {
516+
t.Errorf("wrong p30, expected 30+-10 got %v", value.(float64))
517517
}
518518
}
519519
if strings.Contains(valueName, "p70") {
520-
if math.Abs(value.(float64)-70) > 5 {
521-
t.Errorf("wrong p70, expected 70+-5 got %v", value.(float64))
520+
if math.Abs(value.(float64)-70) > 10 {
521+
t.Errorf("wrong p70, expected 70+-10 got %v", value.(float64))
522522
}
523523
}
524524
if strings.Contains(valueName, "p90") {
525-
if math.Abs(value.(float64)-90) > 5 {
526-
t.Errorf("wrong p90, expected 90+-5 got %v", value.(float64))
525+
if math.Abs(value.(float64)-90) > 10 {
526+
t.Errorf("wrong p90, expected 90+-10 got %v", value.(float64))
527527
}
528528
}
529529
if strings.Contains(valueName, "count") {

0 commit comments

Comments
 (0)