Skip to content

Commit 9c046a4

Browse files
sawenzelclaude
andcommitted
Close the nanometre gaps between EMCAL modules
This fixes the placement of the tilted EMCAL modules so that neighbouring modules touch exactly in eta. - The TRD1 outer width m2Trd1Dx2 was a float, so the module side faces were tilted by about 1e-8 rad against the module chain, leaving 0.05 to 3 nm of supermodule air between every eta neighbour pair. - The centre of the first module put its inner corner 67 nm below the radius used by the rest of the chain, so row 0 overlapped row 1 by up to 2.5 nm and extruded 67 nm from the supermodule. - m2Trd1Dx2 is now a double and the first module centre uses the same corner convention as ShishKebabTrd1Module::Init. - Geant4 and VecGeom navigation stepped into these slivers, where photons below the 1 MeV default cut of the supermodule air were killed. https://its.cern.ch/jira/browse/O2-7334 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent c419989 commit 9c046a4

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎Detectors/EMCAL/base/include/EMCALBase/Geometry.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ class Geometry
222222
Int_t GetNCells() const { return mNCells; }
223223
Float_t GetLongModuleSize() const { return mLongModuleSize; }
224224
Float_t GetTrd1Angle() const { return mTrd1Angle; }
225-
Float_t Get2Trd1Dx2() const { return m2Trd1Dx2; }
225+
Double_t Get2Trd1Dx2() const { return m2Trd1Dx2; }
226226
Float_t GetTrd1AlFrontThick() const { return mTrd1AlFrontThick; }
227227
Float_t GetTrd1BondPaperThick() const { return mTrd1BondPaperThick; }
228228
// --
@@ -699,7 +699,7 @@ class Geometry
699699

700700
// TRD1 options - 30-sep-04
701701
Float_t mTrd1Angle = 0; ///< angle in x-z plane (in degree)
702-
Float_t m2Trd1Dx2 = 0; ///< 2*dx2 for TRD1
702+
Double_t m2Trd1Dx2 = 0; ///< 2*dx2 for TRD1
703703
Float_t mPhiGapForSM = 0; ///< Gap betweeen supermodules in phi direction
704704

705705
// Oct 26,2010

‎Detectors/EMCAL/base/src/ShishKebabTrd1Module.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ void ShishKebabTrd1Module::DefineFirstModule(const Int_t key)
189189
mTheta = 89.25 * TMath::DegToRad();
190190
Double_t al1 = sangle / 2.;
191191
Double_t x = 0.5 * (sa * TMath::Cos(al1) + sb * TMath::Sin(al1));
192-
Double_t y = 0.5 * (sb + sa * TMath::Sin(al1)) * TMath::Cos(al1);
192+
Double_t y = 0.5 * (sb * TMath::Cos(al1) + sa * TMath::Sin(al1)); // inner right corner on r = sr, as in Init()
193193
mOK.Set(x, sr + y);
194194
// parameters of right line : y = A*z + B in system where zero point is IP.
195195
mThetaA = mTheta - sangle / 2.;

0 commit comments

Comments
 (0)