move defaults to constants

Author: AlaaSarhan

src/Flatten.php

@@ -8,6 +8,10 @@
  */
 class Flatten
 {
+    const DEFAULT_SEPARATOR = '.';
+    const DEFAULT_PREFIX = '';
+    const DEFAULT_FLAGS = 0;
+
     /**
      * Turn off flattening values with integer keys.
      */
@@ -35,8 +39,11 @@ class Flatten
      * @return Flatten
      * @see Flatten::FLAG_NUMERIC_NOT_FLATTENED
      */
-    public function __construct($separator = '.', $prefix = '', $flags = 0)
-    {
+    public function __construct(
+        $separator = self::DEFAULT_SEPARATOR,
+        $prefix = self::DEFAULT_PREFIX,
+        $flags = self::DEFAULT_FLAGS
+    ) {
         $this->separator = $separator;
         $this->prefix = $prefix;
         $this->flags = $flags;

test/FlattenTest.php

@@ -23,9 +23,9 @@ public function scalarProvider()
      * @covers Flatten::flatten
      * @dataProvider scalarProvider
      */
-    public function testFlattenScalar($input, $expectedOutput)
+    public function testFlattenScalar($var, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten())->flatten($input));
+        $output = $this->flattenToArray($var);
 
         $this->assertEquals($expectedOutput, $output);
     }
@@ -48,7 +48,7 @@ public function scalarSeparatorPrefixProvider()
      */
     public function testFlattenScalarWithSeparatorAndPrefix($var, $separator, $prefix, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten($separator, $prefix))->flatten($var));
+        $output = $this->flattenToArray($var, $separator, $prefix);
 
         $this->assertEquals($expectedOutput, $output);
     }
@@ -78,9 +78,9 @@ public function arraysProvider()
      * @covers Flatten::flatten
      * @dataProvider arraysProvider
      */
-    public function testFlattenArrays($input, $expectedOutput)
+    public function testFlattenArrays($var, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten())->flatten($input));
+        $output = $this->flattenToArray($var);
 
         $this->assertEquals($expectedOutput, $output);
     }
@@ -114,9 +114,9 @@ public function traversablesProvider()
      * @covers Flatten::flatten
      * @dataProvider traversablesProvider
      */
-    public function testFlattenTraversable($input, $expectedOutput)
+    public function testFlattenTraversable($var, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten())->flatten($input));
+        $output = $this->flattenToArray($var);
         $this->assertEquals($expectedOutput, $output);
     }
 
@@ -157,7 +157,7 @@ public function traversablesSeparatorPrefixProvider()
      */
     public function testFlattenTraversableWithSeparatorAndPrefix($var, $separator, $prefix, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten($separator, $prefix))->flatten($var));
+        $output = $this->flattenToArray($var, $separator, $prefix);
         $this->assertEquals($expectedOutput, $output);
     }
 
@@ -216,7 +216,16 @@ public function flattenWithFlagsProvidor()
      */
     public function testFlattenWithFlags($var, $separator, $prefix, $flags, $expectedOutput)
     {
-        $output = iterator_to_array((new Flatten($separator, $prefix, $flags))->flatten($var));
+        $output = $this->flattenToArray($var, $separator, $prefix, $flags);
         $this->assertEquals($expectedOutput, $output);
     }
+
+    private function flattenToArray(
+        $var,
+        $separator = Flatten::DEFAULT_SEPARATOR,
+        $prefix = Flatten::DEFAULT_PREFIX,
+        $flags = Flatten::DEFAULT_FLAGS
+    ) {
+        return iterator_to_array((new Flatten($separator, $prefix, $flags))->flatten($var));
+    }
 }