Skip to content

Commit 70db557

Browse files
authored
Merge pull request #234 from Adyen/client-bug-fix
Fix usage of xapikey in the kwargs of the methods
2 parents 1a4a7c1 + c5b3fe3 commit 70db557

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed

Adyen/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ def _set_credentials(self, service, endpoint, **kwargs):
331331
# fallback to root module
332332
# and ensure that it is set.
333333

334-
return xapikey, username, password
334+
return xapikey, username, password, kwargs
335335

336336
def _set_platform(self, **kwargs):
337337
# platform at self object has highest priority. fallback to root module
@@ -383,7 +383,7 @@ def call_adyen_api(
383383
self._init_http_client()
384384

385385
# Set credentials
386-
xapikey, username, password = self._set_credentials(service, endpoint, **kwargs)
386+
xapikey, username, password, kwargs= self._set_credentials(service, endpoint, **kwargs)
387387
# Set platform
388388
platform = self._set_platform(**kwargs)
389389
message = request_data

test/CheckoutTest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,3 +597,4 @@ def test_update_payment_link(self):
597597
json=request
598598
)
599599
self.assertEqual("expired",result.message["status"])
600+

test/UtilTest.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
is_valid_hmac_notification,
77
get_query
88
)
9+
try:
10+
from BaseTest import BaseTest
11+
except ImportError:
12+
from .BaseTest import BaseTest
913

1014

1115
class UtilTest(unittest.TestCase):
@@ -67,4 +71,20 @@ def test_query_string_creation(self):
6771
"pageNumber":3
6872
}
6973
query_string = get_query(query_parameters)
70-
self.assertEqual(query_string,'?pageSize=7&pageNumber=3')
74+
self.assertEqual(query_string,'?pageSize=7&pageNumber=3')
75+
76+
def test_passing_xapikey_in_method(self):
77+
request = {'merchantAccount': "YourMerchantAccount"}
78+
self.test = BaseTest(self.ady)
79+
self.client.platform = "test"
80+
self.ady.client = self.test.create_client_from_file(200, request,
81+
"test/mocks/"
82+
"checkout/"
83+
"paymentmethods"
84+
"-success.json")
85+
result = self.ady.checkout.payments_api.payment_methods(request, xapikey="YourXapikey")
86+
self.assertEqual("AliPay", result.message['paymentMethods'][0]['name'])
87+
self.assertEqual("Credit Card",
88+
result.message['paymentMethods'][2]['name'])
89+
self.assertEqual("Credit Card via AsiaPay",
90+
result.message['paymentMethods'][3]['name'])

0 commit comments

Comments
 (0)