Fix Clang compilation.

Author: Adnn

src/apps/ch10_area_lights/ch10_area_lights/CameraSystem.cpp

@@ -23,7 +23,7 @@ void OrbitalCamera::setRatio(float aAspectRatio)
 #else
     mCamera.setupPerspectiveProjection({
         .mAspectRatio = aAspectRatio,
-        .mVerticalFov = math::Radian{math::pi<float>/2.f},
+        .mVerticalFov = math::Radian<float>{math::pi<float>/2.f},
         .mNearZ = -0.1f,
         .mFarZ = -20.f }
     );

src/apps/ch10_area_lights/ch10_area_lights/log/Logging-init.cpp

@@ -38,7 +38,7 @@ void ad_rtr_ch10_loggerinitialization()
 //
 #else
 
-namespace ad::renderer {
+namespace ad {
 
 
 std::tuple<std::shared_ptr<spdlog::logger>>

src/apps/ch10_ltc/ch10_ltc/CameraSystem.cpp

@@ -20,7 +20,7 @@ void OrbitalCamera::setRatio(float aAspectRatio)
     //);
     mCamera.setupPerspectiveProjection({
         .mAspectRatio = aAspectRatio,
-        .mVerticalFov = math::Radian{math::pi<float>/2.f},
+        .mVerticalFov = math::Radian<float>{math::pi<float>/2.f},
         .mNearZ = -0.1f,
         .mFarZ = -20.f }
     );

src/apps/ch10_ltc/ch10_ltc/Scene.cpp

@@ -413,7 +413,7 @@ void Scene::render(math::Size<2, int> aRenderResolution)
 
 std::string to_string(Scene::FrameControl::AppMode aValue)
 {
-#define STR(enumerator) case Scene::FrameControl::AppMode::##enumerator: return #enumerator
+#define STR(enumerator) case Scene::FrameControl::AppMode::enumerator: return #enumerator
     switch (aValue)
     {
         STR(Fig2);
@@ -428,7 +428,7 @@ std::string to_string(Scene::FrameControl::AppMode aValue)
 
 std::string to_string(Scene::FigureControl::Letter aValue)
 {
-#define STR(enumerator) case Scene::FigureControl::##enumerator: return #enumerator
+#define STR(enumerator) case Scene::FigureControl::enumerator: return #enumerator
     switch (aValue)
     {
         STR(a);

src/apps/ch10_ltc/ch10_ltc/log/Logging-init.cpp

@@ -22,7 +22,7 @@ LoggerInitialization::LoggerInitialization()
 const LoggerInitialization LoggerInitialization::gInitialized;
 
 
-} // namespace ad::renderer
+} // namespace ad
 
 
 void ad_rtr_ch10_loggerinitialization()
@@ -38,7 +38,7 @@ void ad_rtr_ch10_loggerinitialization()
 //
 #else
 
-namespace ad::renderer {
+namespace ad {
 
 
 std::tuple<std::shared_ptr<spdlog::logger>>

src/apps/ch11_ssao/ch11_ssao/FrameGraph.cpp

@@ -1,5 +1,6 @@
 #include "FrameGraph.h"
 
+#include "log/Logging.h"
 #include "SetupDrawing.h"
 #include "UniformSetterWitness.h"
 
@@ -94,7 +95,7 @@ DESCRIBE(FrameGraph::BlurControl)
 
 std::string to_string(TextureStore::Name aName)
 {
-#define STR(enumerator) case TextureStore::##enumerator: return #enumerator
+#define STR(enumerator) case TextureStore::enumerator: return #enumerator
     switch (aName)
     {
         STR(DepthMap);
@@ -769,6 +770,9 @@ void FrameGraph::appendUi()
     case FrameGraph::SsaoMethod::OrientedHemishphere:
         describe(witness, mHemisphereSsaoControl);
         break;
+    default:
+        ADLOG(warn)("Unhandled SSAO method value: {}.", (unsigned int)mSsaoMethod);
+        break;
     }
 
     ImGui::SeparatorText("AO Blur");

src/apps/ch11_ssao/ch11_ssao/SetupDrawing.cpp

@@ -103,7 +103,7 @@ graphics::VertexArrayObject prepareVAO(const renderer::IntrospectProgram & aProg
             assert(elementSize <= 16);
             const GLsizeiptr bufferSize = elementSize * aMesh.mVertexCount;
             scenic::BufferView dummyBufferView{
-                .mGLBuffer = accessor.mBuffer,
+                .mGLBuffer = {accessor.mBuffer},
                 .mStride = elementSize,
                 .mInstanceDivisor = 0, // All attributes from a Naive MeshPart are per vertex
                 .mOffset = 0,
@@ -206,6 +206,6 @@ void setTextures(const IntrospectProgram & aProgram,
         }
     }
 }
-#endif 0
+#endif
 
 } // namespace ad

src/apps/ch11_ssao/ch11_ssao/log/Logging-init.cpp

@@ -39,7 +39,7 @@ void ad_rtr_ch10_loggerinitialization()
 //
 #else
 
-namespace ad::renderer {
+namespace ad {
 
 
 std::tuple<std::shared_ptr<spdlog::logger>>

src/apps/ch11_ssao/ch11_ssao/main.cpp

@@ -77,17 +77,17 @@ int main(int argc, const char* argv[])
                 if (resetStatus == GL_GUILTY_CONTEXT_RESET)
                 {
                     ADLOG_THROW(critical, "OpenGL: Guilty context reset (likely caused by the application).");
-                    terminate();
+                    std::terminate();
                 }
                 else if (resetStatus == GL_INNOCENT_CONTEXT_RESET)
                 {
                     ADLOG_THROW(critical, "OpenGL: Innocent context reset (external cause).");
-                    terminate();
+                    std::terminate();
                 }
                 else if (resetStatus == GL_UNKNOWN_CONTEXT_RESET)
                 {
                     ADLOG_THROW(critical, "OpenGL: Unknown context reset (cause undetermined).");
-                    terminate();
+                    std::terminate();
                 }
             }
         }

src/libs/engine/engine/files/Loader.cpp

@@ -25,7 +25,7 @@ namespace {
 
 
     // TODO: move that to a low level utils lib (handy)
-    constexpr std::uint32_t makeFourCC(char a, char b, char c, char d)
+    [[maybe_unused]] constexpr std::uint32_t makeFourCC(char a, char b, char c, char d)
     {
         return (std::uint32_t)a 
             | ((std::uint32_t)b << 8)