BLE: correctness improvments

Remove unused variable, improve header inclusion, fix initialization list order,

Author: pan-

connectivity/FEATURE_BLE/include/ble/gap/AdvertisingDataSimpleBuilder.h

@@ -68,7 +68,7 @@ class AdvertisingDataSimpleBuilder {
     /**
      * Construct a AdvertisingDataSimpleBuilder
      */
-    AdvertisingDataSimpleBuilder() : _builder(_buffer), _buffer()
+    AdvertisingDataSimpleBuilder() : _buffer(), _builder(_buffer)
     {
     }
 

connectivity/FEATURE_BLE/source/cordio/source/GattServerImpl.cpp

@@ -991,8 +991,6 @@ uint8_t GattServer::atts_write_cb(
     attsAttr_t *pAttr
 )
 {
-    uint8_t err;
-
     GattCharacteristic* auth_char = getInstance().get_auth_char(handle);
     if (auth_char && auth_char->isWriteAuthorizationEnabled()) {
         GattWriteAuthCallbackParams write_auth_params = {

connectivity/FEATURE_BLE/source/generic/GapImpl.h

@@ -37,11 +37,7 @@
 #include "ble/gap/Events.h"
 
 #include "source/pal/PalGap.h"
-#include "source/pal/GapEvents.h"
-#include "source/pal/GapTypes.h"
-#include "source/pal/PalEventQueue.h"
 #include "source/pal/PalConnectionMonitor.h"
-#include "source/pal/PalEventQueue.h"
 
 #include "ble/Gap.h"
 
@@ -53,6 +49,8 @@ class PalSecurityManager;
 
 class PalGap;
 
+class PalEventQueue;
+
 namespace impl {
 
 class BLEInstanceBase;