100% code coverage

Author: TomHAnderson

src/ApiProblem.php

@@ -183,10 +183,6 @@ public function __get(string $name): mixed
             return $this->{$prop};
         }
 
-        if (isset($this->additionalDetails[$name])) {
-            return $this->additionalDetails[$name];
-        }
-
         if (isset($this->additionalDetails[$normalized])) {
             return $this->additionalDetails[$normalized];
         }
@@ -221,7 +217,8 @@ public function toArray(): array
      *
      * @param mixed[] $params
      */
-    public function response(array ...$params): JsonResponse
+    // phpcs:ignore SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint
+    public function response(...$params): JsonResponse
     {
         $apProblem = null;
 
@@ -314,11 +311,7 @@ protected function getTitle(): string
             return get_class($this->detail);
         }
 
-        if ($this->title === null) {
-            return 'Unknown';
-        }
-
-        return $this->title;
+        return 'Unknown';
     }
 
     /**

test/ApiProblemTest.php

@@ -6,6 +6,9 @@
 
 use ApiSkeletons\Laravel\ApiProblem\ApiProblem;
 use ApiSkeletons\Laravel\ApiProblem\Exception;
+use ApiSkeletons\Laravel\ApiProblem\Facades\ApiProblem as ApiProblemFacade;
+use http\Exception\InvalidArgumentException;
+use Illuminate\Http\JsonResponse;
 use ReflectionObject;
 use TypeError;
 
@@ -27,6 +30,18 @@ public function statusCodes(): array
         ];
     }
 
+    public function testResponseWithObject(): void
+    {
+        $apiProblem = new ApiProblem(500, 'Testing');
+
+        $this->assertInstanceOf(JsonResponse::class, $apiProblem->response());
+    }
+
+    public function testResponseWithFacade(): void
+    {
+        $this->assertInstanceOf(JsonResponse::class, ApiProblemFacade::response('Testing', 500));
+    }
+
     /**
      * @dataProvider statusCodes
      */
@@ -255,4 +270,52 @@ public function testInvalidHttpStatusCodesAreCastTo500(int $code): void
         $problem = new ApiProblem($code, $e);
         $this->assertEquals(500, $problem->status);
     }
+
+    /**
+     * @dataProvider statusCodes
+     * @group api-tools-118
+     */
+    public function testMagicGetInvalidArgument(int $code): void
+    {
+        $this->expectException(Exception\InvalidArgumentException::class);
+        $apiProblem = new ApiProblem($code, 'Testing', null, null, ['more' => 'testing']);
+
+        $this->assertEquals('testing', $apiProblem->code);
+    }
+
+    /**
+     * @dataProvider statusCodes
+     * @group api-tools-118
+     */
+    public function testMagicGetNormalizedProperties(int $code): void
+    {
+        $apiProblem = new ApiProblem($code, 'Testing', 'test', 'title test', ['more' => 'testing']);
+
+        $this->assertEquals('test', $apiProblem->__get('type'));
+        $this->assertEquals($code, $apiProblem->__get('status'));
+        $this->assertEquals('title test', $apiProblem->__get('title'));
+        $this->assertEquals('Testing', $apiProblem->__get('detail'));
+    }
+
+    /**
+     * @dataProvider statusCodes
+     * @group api-tools-118
+     */
+    public function testMagicGetAdditionalDetails(int $code): void
+    {
+        $apiProblem = new ApiProblem($code, 'Testing', 'test', 'title test', ['xxmore' => 'testing']);
+
+        $this->assertEquals('testing', $apiProblem->__get('xxmore'));
+    }
+
+    /**
+     * @dataProvider statusCodes
+     * @group api-tools-118
+     */
+    public function testMagicGetAdditionalDetailsNormalized(int $code): void
+    {
+        $apiProblem = new ApiProblem($code, 'Testing', 'test', 'title test', ['code' => 'testing']);
+
+        $this->assertEquals('testing', $apiProblem->__get('code'));
+    }
 }