Core 13 #60
Open
Core 13 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingcongBai
changed the title
This feature is supported by Binutils on amd64, arm64, loongarch64, and ppc64el.
-D_FORTIFY_SOURCE requires optimisation (-O) and may cause build failures if a build system passes only CPPFLAGS but not C/CXXFLAGS (i.e., Binutils and GCC, and we are not sure if this has caused further silent failures elsewhere). Since it would not do much harm to pass our lowest optimisation level on its own, pass -O2 as part of the AB_FLAGS_FTF condition.
We choose to add NOPERMISSIVE instead of removing it completely, because plenty of (old) C++ projects requires this to build using newer GCC versions, such as ncurses (C++ bindings and implementation), and libstdc++ on some architectures.
GCC 15 introduces a new compiler flag, `-m{,no-}fence-tso`, to control
the usage of `fence.tso` instruction (which is not supported on some old
T-Head cores, such as the ones used on TH1520/SG2042). When it's
disabled, more strong `fence rw,rw` is emitted and correctness is
then not affected.
Disable emitting this instruction now, because all buildbots of riscv64
are currently SG2042, and no CPU cores are known to benefit from
`fence.tso` yet.
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
This will be stored on a separated list and will be passed along with __AB_SONAMES for manually specifying sonames for Spiral. See core-devel/gcc/01-runtime/beyond for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is supported by Binutils on amd64, arm64, loongarch64, and ppc64el.