Skip to content

Conversation

@DannyLiCom
Copy link
Collaborator

Description

Fix generate_metrics_and_upload_to_big_query flag and related dependencies.

FIXES: b/441984274, b/446097400

Tests

Project preparation:

  • Create a dataset in BigQuery or use an existed one in the target project

benchmarks/recipes/user_configs.py change:
Adding the following flags to

# Define the required configuration here
USER_CONFIG = UserConfig(
  • Set bq_enable to True
  • Set bq_db_project and bq_db_dataset to the user's target project and the dataset in the target project
    Run the command python3 -m benchmarks.recipes.pw_mcjax_benchmark_recipe and after 20 steps, one big query record will be written to the run_summary table of the target dataset

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@DannyLiCom DannyLiCom marked this pull request as ready for review November 20, 2025 07:47
@DannyLiCom DannyLiCom changed the title Add Big Qurey necessary dependencies Fix generate_metrics_and_upload_to_big_query Nov 23, 2025
@DannyLiCom DannyLiCom force-pushed the lidanny/bq_fix_mini branch 2 times, most recently from 260d4ef to eedb975 Compare November 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants