From 451cc9750cbfce706e650ee4e949c6758a2971db Mon Sep 17 00:00:00 2001 From: Richard Lock Date: Mon, 11 Nov 2024 12:42:19 -0500 Subject: [PATCH 1/2] fix: syntax issues --- src/teamwork.sh | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/teamwork.sh b/src/teamwork.sh index 1dac33de..2896a280 100644 --- a/src/teamwork.sh +++ b/src/teamwork.sh @@ -202,11 +202,10 @@ teamwork::pull_request_review_submitted() { --- -Review: **$review_state ✅** +Review: **$review_state ✅**" if [ -z $comment ]; then - Comment: $comment + teamwork::add_comment "Comment: $comment" fi -" teamwork::add_tag "PR Approved" teamwork::remove_tag "PR Changes Requested" teamwork::move_task_to_column "$BOARD_COLUMN_REVIEWED" @@ -219,11 +218,11 @@ fi --- -Review: **$review_state 😔** +Review: **$review_state 😔**" if [ -z $comment ]; then - Comment: $comment + teamwork::add_comment "Comment: $comment" fi -" + teamwork::add_tag "PR Changes Requested" teamwork::remove_tag "PR Approved" teamwork::move_task_to_column "$BOARD_COLUMN_REVIEWED" @@ -232,13 +231,10 @@ fi teamwork::pull_request_review_dismissed() { local -r user=$(github::get_sender_user) - teamwork::add_comment "Review dismissed by $user - + teamwork::add_comment "Review dismissed by $user" if [ -z $comment ]; then - --- - Comment: $comment + teamwork::add_comment "Comment: $comment" fi - " teamwork::remove_tag "PR Open" teamwork::remove_tag "PR Approved" teamwork::remove_tag "Changes Requested" From 5837462bf816d0d44248a098346690fbe72f9db4 Mon Sep 17 00:00:00 2001 From: Richard Lock Date: Mon, 11 Nov 2024 12:45:25 -0500 Subject: [PATCH 2/2] fix: lint syntax issues --- src/teamwork.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/teamwork.sh b/src/teamwork.sh index 2896a280..a609d0bc 100644 --- a/src/teamwork.sh +++ b/src/teamwork.sh @@ -203,7 +203,7 @@ teamwork::pull_request_review_submitted() { --- Review: **$review_state ✅**" -if [ -z $comment ]; then +if [ -z "$comment" ]; then teamwork::add_comment "Comment: $comment" fi teamwork::add_tag "PR Approved" @@ -219,7 +219,7 @@ fi --- Review: **$review_state 😔**" -if [ -z $comment ]; then +if [ -z "$comment" ]; then teamwork::add_comment "Comment: $comment" fi @@ -232,7 +232,7 @@ fi teamwork::pull_request_review_dismissed() { local -r user=$(github::get_sender_user) teamwork::add_comment "Review dismissed by $user" - if [ -z $comment ]; then + if [ -z "$comment" ]; then teamwork::add_comment "Comment: $comment" fi teamwork::remove_tag "PR Open"