update thread safe code

Author: 7bitcoder

Include/SevenBit/DI/Details/Containers/Impl/ServiceInstancesMap.hpp

@@ -42,9 +42,9 @@ namespace sb::di::details
         {
             for (auto it = _constructionOrder.rbegin(); it != _constructionOrder.rend(); ++it)
             {
-                if (const auto list = findInstances(*it))
+                if (const auto listPtr = findInstances(*it))
                 {
-                    list->clear();
+                    listPtr->clear();
                 }
             }
         }

README.md

@@ -17,7 +17,7 @@
   </p>
 
   <h4>
-    <a href="https://7bitDI.readthedocs.io/en/latest/index.html">Documentation & Examples</a>
+    <a href="https://7bitDI.readthedocs.io">Documentation & Examples</a>
   </h4>
 </div>
 
@@ -52,6 +52,10 @@ The library is officially supported on the following platforms:
 If you notice any problems/bugs, please file an issue on the repository GitHub Issue Tracker. Pull requests containing
 fixes are welcome!
 
+## Documentation
+
+https://7bitDI.readthedocs.io
+
 ## Installation
 
 ### There are a few ways of installation:
@@ -230,6 +234,6 @@ actionA, actionB executed.
 ```
 
 More examples and tutorials are available on the
-[Documentation & Examples](https://7bitDI.readthedocs.io/en/latest/index.html) page
+[Documentation & Examples](https://7bitDI.readthedocs.io) page
 
 @7bitcoder Sylwester Dawida 2023

Tests/Integration/ThreadSafeTest.cpp

@@ -0,0 +1,80 @@
+#include <gtest/gtest.h>
+#include <thread>
+
+#include "../Helpers/Classes/Basic.hpp"
+#include "../Helpers/Classes/CirularDependency.hpp"
+#include "../Helpers/Classes/Complex.hpp"
+#include <SevenBit/DI/Exceptions.hpp>
+#include <SevenBit/DI/ServiceCollection.hpp>
+
+class ThreadSafeTest : public testing::Test
+{
+  protected:
+    static void SetUpTestSuite() {}
+
+    ThreadSafeTest() {}
+
+    void SetUp() override {}
+
+    void TearDown() override {}
+
+    ~ThreadSafeTest() override = default;
+
+    static void TearDownTestSuite() {}
+};
+
+void getSafeServices(sb::di::ServiceProvider &provider)
+{
+    auto &service1 = provider.getService<ITestComplexClass1>();
+    auto &service2 = provider.getService<ITestComplexClass2>();
+    auto service3 = provider.createService<ITestComplexClass3>();
+    auto &service4 = provider.getService<ITestComplexClass4>();
+    auto &service5 = provider.getService<ITestComplexClass5>();
+    auto &service6 = provider.getService<ITestComplexClass6>();
+
+    EXPECT_EQ(service1.number(), 1);
+    EXPECT_EQ(service2.number(), 2);
+    EXPECT_EQ(service3->number(), 3);
+    EXPECT_EQ(service4.number(), 4);
+    EXPECT_EQ(service5.number(), 5);
+    EXPECT_EQ(service6.number(), 6);
+    EXPECT_EQ(service2.getOne(), &service1);
+    EXPECT_EQ(service3->getOne(), &service1);
+    EXPECT_EQ(service3->getTwo(), &service2);
+    EXPECT_EQ(service4.getOne(), &service1);
+    EXPECT_EQ(service4.getTwo(), &service2);
+    EXPECT_NE(service4.getThree().get(), service3.get());
+    EXPECT_EQ(service5.getOne(), &service1);
+    EXPECT_EQ(service5.getTwo(), &service2);
+    EXPECT_NE(service5.makeThree(), service3);
+    EXPECT_EQ(&service6.getOne(), &service1);
+    EXPECT_EQ(&service6.getTwo(), &service2);
+    EXPECT_FALSE(service6.getNonExisting());
+    EXPECT_NE(service6.makeThree(), service3);
+}
+
+TEST_F(ThreadSafeTest, ShouldGetSafeServices)
+{
+    sb::di::ServiceProviderOptions options;
+    options.threadSafe = true;
+
+    auto provider = sb::di::ServiceCollection{}
+                        .addSingleton<ITestComplexClass1, TestComplexClass1>()
+                        .addSingleton<ITestComplexClass2, TestComplexClass2>()
+                        .addTransient<ITestComplexClass3, TestComplexClass3>()
+                        .addScoped<ITestComplexClass4, TestComplexClass4>()
+                        .addScoped<ITestComplexClass5, TestComplexClass5>()
+                        .addScoped<ITestComplexClass6, TestComplexClass6>()
+                        .buildServiceProvider(options);
+
+    std::vector<std::thread> threads;
+    constexpr size_t maxThreads = 50;
+    for (size_t i = 0; i < maxThreads; ++i)
+    {
+        threads.emplace_back(getSafeServices, std::ref(provider));
+    }
+    for (auto &th : threads)
+    {
+        th.join();
+    }
+}